Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lidar_apollo_instance_segmentation): add ignore directory #3381

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 12, 2023

Description

Untracked files:                                                                                                                                                                                                                                                                                                                                                                                                                
  (use "git add <file>..." to include in what will be committed)                                                                                                                                                                                                                                                                                                                                                                
        perception/lidar_apollo_instance_segmentation/data/  

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota requested review from yukkysaito and a team as code owners April 12, 2023 10:17
@satoshi-ota satoshi-ota requested a review from wep21 April 12, 2023 10:17
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21
Copy link
Contributor

wep21 commented Apr 12, 2023

@yukkysaito I'm sorry, but could you approve this PR?

@wep21 wep21 enabled auto-merge (squash) April 12, 2023 10:22
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3aead0d) 12.33% compared to head (7facc6c) 12.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3381      +/-   ##
==========================================
- Coverage   12.33%   12.33%   -0.01%     
==========================================
  Files        1381     1381              
  Lines       96627    96621       -6     
  Branches    27925    27923       -2     
==========================================
- Hits        11919    11918       -1     
+ Misses      72079    72074       -5     
  Partials    12629    12629              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.33% <ø> (+<0.01%) ⬆️ Carriedforward from 3aead0d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
control/mpc_lateral_controller/src/mpc.cpp 48.31% <ø> (-0.14%) ⬇️
...elevation_map_loader/elevation_map_loader_node.hpp 0.00% <ø> (ø)
...ation_map_loader/src/elevation_map_loader_node.cpp 0.00% <ø> (ø)
...e/lidar_apollo_instance_segmentation/cluster2d.hpp 0.00% <ø> (ø)
...de/lidar_apollo_instance_segmentation/debugger.hpp 0.00% <ø> (ø)
...de/lidar_apollo_instance_segmentation/detector.hpp 0.00% <ø> (ø)
...idar_apollo_instance_segmentation/disjoint_set.hpp 0.00% <ø> (ø)
...apollo_instance_segmentation/feature_generator.hpp 0.00% <ø> (ø)
...lidar_apollo_instance_segmentation/feature_map.hpp 0.00% <ø> (ø)
...nclude/lidar_apollo_instance_segmentation/node.hpp 0.00% <ø> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit 1b1650d into autowarefoundation:main Apr 12, 2023
@satoshi-ota satoshi-ota deleted the chore/ignore-file branch April 12, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants