Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): add flag to enable creep towards intersection occlusion #3510

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 24, 2023

Description

If intersection occlusion is enabled, the creep velocity for intersection occlusion will not be used.

Tests performed

planning simulator works well

Effects on system behavior

If intersection occlusion is enabled, the creep velocity for intersection occlusion will not be used.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <[email protected]>
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (1d4bf8e) 14.67% compared to head (9a87dee) 14.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   14.67%   14.61%   -0.06%     
==========================================
  Files        1292     1294       +2     
  Lines       91647    92005     +358     
  Branches    28835    29071     +236     
==========================================
  Hits        13451    13451              
- Misses      63752    64106     +354     
- Partials    14444    14448       +4     
Flag Coverage Δ *Carryforward flag
differential 3.46% <0.00%> (?)
total 14.69% <ø> (+0.01%) ⬆️ Carriedforward from 1d4bf8e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <ø> (ø)
...nner/include/scene_module/intersection/manager.hpp 0.00% <ø> (ø)
...e/scene_module/intersection/scene_intersection.hpp 0.00% <0.00%> (ø)
...er/include/scene_module/intersection/util_type.hpp 0.00% <0.00%> (ø)
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soblin soblin merged commit 2a0f760 into autowarefoundation:main Apr 24, 2023
@soblin soblin deleted the feat/disable-creep-towards-intersection-occlusion branch April 24, 2023 05:40
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…lusion (autowarefoundation#3510)

* feat(intersection): add flag to enable creep towards intersection occlusion

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Mingyu Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants