Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fixed to restart after occlusion is cleared #3552

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 26, 2023

Description

Prior this PR, ego vehicle keeps stopping at the peeking stop line after occlusion gets cleared.

Related links

Tests performed

RTC works as before.

Before this PR

ego stucks

collision_after_occlusion-2023-04-26_23.38.39.mp4

After this PR

collision_after_occlusion-2023-04-26_23.36.08.mp4

Notes for reviewers

Interface changes

ego restarts after occlusion is cleared.

Effects on system behavior

ego restarts after occlusion is cleared.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c3a860) 14.08% compared to head (88659f4) 14.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3552   +/-   ##
=======================================
  Coverage   14.08%   14.08%           
=======================================
  Files        1399     1399           
  Lines       97918    97917    -1     
  Branches    29058    29057    -1     
=======================================
  Hits        13788    13788           
  Misses      69459    69459           
+ Partials    14671    14670    -1     
Flag Coverage Δ *Carryforward flag
differential 3.45% <0.00%> (?)
total 14.08% <ø> (+<0.01%) ⬆️ Carriedforward from 2c3a860

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 19.73% <ø> (+0.02%) ⬆️
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 70c3ee4 into autowarefoundation:main Apr 27, 2023
@soblin soblin deleted the fix/restart-after-occlusion branch April 27, 2023 04:35
soblin added a commit to tier4/autoware.universe that referenced this pull request May 1, 2023
…arefoundation#3552)

fixed to restart after occlusion disappeared

Signed-off-by: Mamoru Sobue <[email protected]>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 1, 2023
…arefoundation#3552)

fixed to restart after occlusion disappeared

Signed-off-by: Mamoru Sobue <[email protected]>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 1, 2023
fix(intersection): fixed to restart after occlusion is cleared (autowarefoundation#3552)

fixed to restart after occlusion disappeared

Signed-off-by: Mamoru Sobue <[email protected]>
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
…arefoundation#3552)

fixed to restart after occlusion disappeared

Signed-off-by: Mamoru Sobue <[email protected]>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…arefoundation#3552)

fixed to restart after occlusion disappeared

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mingyu Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants