-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance_by_lane_change): reuse lane change class #3577
refactor(avoidance_by_lane_change): reuse lane change class #3577
Conversation
ab2359e
to
16be270
Compare
7ac9f85
to
31c9179
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
==========================================
+ Coverage 13.72% 13.74% +0.01%
==========================================
Files 1397 1398 +1
Lines 98263 98130 -133
Branches 29238 29158 -80
==========================================
+ Hits 13490 13491 +1
+ Misses 70233 70096 -137
- Partials 14540 14543 +3
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar <[email protected]>
Signed-off-by: Muhammad Zulfaqar <[email protected]>
Signed-off-by: Muhammad Zulfaqar <[email protected]>
This reverts commit 16be270.
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
728af6f
to
a4ce35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundation#3577) * refactor(avoidance_by_lane_change): reuse lane change class Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix wrong direction Signed-off-by: Muhammad Zulfaqar <[email protected]> * fix conflict Signed-off-by: Muhammad Zulfaqar <[email protected]> * fix rtc paramters Signed-off-by: Muhammad Zulfaqar <[email protected]> * Revert "fix rtc paramters" This reverts commit 16be270. * fix rtc Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix pre-commit Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix pre-commit and move updateRTCStatus to cpp file Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * COMPILE_WITH_OLD_ARCHITECTURE=TRUE Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Muhammad Zulfaqar <[email protected]> Signed-off-by: Mingyu Li <[email protected]>
Description
Currently,
avoidance_by_lane_change
module has similar implementation to lane change module, with exceptions of path generation functions.The PR aims to unify
avoidance_by_lane_change
tolane change module
.The PR moves
scene_module/avoidance_by_lc/*
content toscene_module/lane_change/avoidance_by_lane_change
and a introduces new classAvoidanceByLaneChangeInterface
that inherits from the LaneChangeInterface, with overridenupdateRTCStatus
. It also improves the maintainability and style of some of the existing classes.Related links
None
Tests performed
Notes for reviewers
getLaneChangePaths
inutils::lane_change
is removed.parameters_
is changed tolane_change_parameters_
avoidance_by_lane_change-.2023-05-01-11-53-39.mp4
avoidance_by_lane_change-.2023-05-01-11-54-17.mp4
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.