Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): output avoidance target marker that are always shown in rviz #3582

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 28, 2023

Description

  • add another markers that contains important information about the avoidance module.
  • the avoidance module outputs avoidable_target_objects and unavoidable_target_objects marker as important information.
  • these markers are always shown in Rviz by default.
  • feat(avoidance): hide detail information autoware_launch#339

Tests performed

Psim

  • RED Cube -> Target objects that is NOT avoidable.
  • YELLOW Cube -> Target objects that is avoidable.

rviz_screenshot_2023_05_03-10_57_40

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 28, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review May 3, 2023 01:58
@satoshi-ota satoshi-ota changed the title feat(avoidance): output avoidance target marker feat(avoidance): output avoidance target marker that are always shown in Rviz May 3, 2023
@satoshi-ota satoshi-ota changed the title feat(avoidance): output avoidance target marker that are always shown in Rviz feat(avoidance): output avoidance target marker that are always shown in rviz May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 21.56% and project coverage change: +0.02 🎉

Comparison is base (ff7c808) 14.59% compared to head (f8bba24) 14.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
+ Coverage   14.59%   14.62%   +0.02%     
==========================================
  Files        1299     1299              
  Lines       92414    92406       -8     
  Branches    29238    29230       -8     
==========================================
+ Hits        13492    13511      +19     
+ Misses      64383    64327      -56     
- Partials    14539    14568      +29     
Flag Coverage Δ *Carryforward flag
differential 12.58% <21.56%> (?)
total 14.60% <ø> (+<0.01%) ⬆️ Carriedforward from ff7c808

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...r_path_planner/src/marker_util/avoidance/debug.cpp 5.08% <17.94%> (+5.08%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.68% <33.33%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit ca9e277 into autowarefoundation:main May 8, 2023
@satoshi-ota satoshi-ota deleted the feat/output-info-avoidance branch May 8, 2023 01:33
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
… in rviz (autowarefoundation#3582)

feat(avoidance): output necessary marker

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: Mingyu Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants