Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix visualization bug #3586

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 29, 2023

Description

In following two patern, the ego doesn't need to shift any more.

  • the object is on RIGHT of the ego' path, and the shift length is LESS than zero.
  • the object is on LEFT of the ego' path, and the shift length is MORE than zero.

Currently, since avoidance module doesn't check these condition explicitly, those objects are shown as IsSameDirectionShift.

rviz_screenshot_2023_04_29-14_56_47

In this PR, I added a funciton to check above condition and push back those objects in other objects (not target objects) as NotNeedAvoidance.

rviz_screenshot_2023_04_29-14_51_20

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota marked this pull request as ready for review April 29, 2023 06:06
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (279b64a) 14.08% compared to head (d8ad0f8) 14.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   14.08%   14.08%   -0.01%     
==========================================
  Files        1396     1396              
  Lines       98021    98033      +12     
  Branches    29077    29086       +9     
==========================================
  Hits        13809    13809              
- Misses      69549    69561      +12     
  Partials    14663    14663              
Flag Coverage Δ *Carryforward flag
differential 15.39% <0.00%> (?)
total 14.08% <ø> (ø) Carriedforward from 279b64a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 3.41% <0.00%> (-0.01%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.82% <0.00%> (-0.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota changed the title fix(avoidance): ignore objects whose shift line length is less than threshold fix(avoidance): fix visualization bug May 8, 2023
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 161e23d into autowarefoundation:main May 8, 2023
@satoshi-ota satoshi-ota deleted the feat/check-shift-necessity branch May 8, 2023 01:33
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
fix(avoidance): ignore objects whose shift line length is less than threshold

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: Mingyu Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants