Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scenario_selector): add off-track test #3592

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Apr 29, 2023

Description

Add a test to check the node will not die when the ego-vehicle pose is located far from the target trajectory.

Related links

#3587 needs to be merged before.

Tests performed

run colcon test.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 18.18% and no project coverage change.

Comparison is base (adf11f0) 13.70% compared to head (35a9dc2) 13.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3592   +/-   ##
=======================================
  Coverage   13.70%   13.70%           
=======================================
  Files        1397     1397           
  Lines       98253    98256    +3     
  Branches    29254    29259    +5     
=======================================
+ Hits        13467    13469    +2     
+ Misses      70235    70227    -8     
- Partials    14551    14560    +9     
Flag Coverage Δ *Carryforward flag
differential 43.15% <18.18%> (?)
total 13.70% <ø> (-0.01%) ⬇️ Carriedforward from adf11f0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._manager/planning_interface_test_manager_utils.hpp 12.06% <ø> (-0.14%) ⬇️
...test_utils/src/planning_interface_test_manager.cpp 43.47% <ø> (-0.07%) ⬇️
...tor/test/test_scenario_selector_node_interface.cpp 28.00% <18.18%> (-2.77%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kyoichi-sugahara
Copy link
Contributor

colcon test success

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
colcon test passed in awf-latest branch and latest beta branch for the product

@TakaHoribe TakaHoribe force-pushed the add-off-track-test-scenario_selector branch from ab2f6be to 35a9dc2 Compare May 5, 2023 02:06
@TakaHoribe TakaHoribe enabled auto-merge (squash) May 8, 2023 04:43
@TakaHoribe TakaHoribe merged commit 23f0a44 into autowarefoundation:main May 8, 2023
@TakaHoribe TakaHoribe deleted the add-off-track-test-scenario_selector branch May 8, 2023 05:01
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants