test(freespace_planner): add off-track test #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakaHoribe
requested review from
kosuke55,
takayuki5168,
purewater0901 and
a team
as code owners
github-actions
bot
added
the
component:planning
kosuke55
approved these changes
Apr 29, 2023
|
colcon test fail |
| // test for normal route | ||
| ASSERT_NO_THROW(test_manager->testWithBehaviorNominalRoute(test_target_node)); | ||
| EXPECT_GE(test_manager->getReceivedTopicNum(), 1); | ||
|
|
There was a problem hiding this comment.
test_manager->setInitialPoseTopicName("freespace_planner/input/odometry");
is necessary to define input_initial_pose_name_
And with this change, colcon test passed
There was a problem hiding this comment.
test_manager->setInitialPoseTopicName("freespace_planner/input/odometry");
is better to be in generateTestManager()?
There was a problem hiding this comment.
Thank you. Addressed in 1d029c4
Signed-off-by: Takamasa Horibe <[email protected]>
TakaHoribe
force-pushed
the
add-off-track-test-freespace_planner
branch
from
8c9a388
to
708759d
Compare
Signed-off-by: Takamasa Horibe <[email protected]>
Mingyu1991
pushed a commit
to Mingyu1991/autoware.universe
that referenced
this pull request
Jun 26, 2023
* test(freespace_planner): add off-track test Signed-off-by: Takamasa Horibe <[email protected]> * add initialpose topic name initialization Signed-off-by: Takamasa Horibe <[email protected]> --------- Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: Mingyu Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test to check the node will not die when the ego-vehicle pose is located far from the target trajectory.
Related links
#3587 needs to be merged before.
Tests performed
run colcon test.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.