Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planner_manager): fix build error #3611

Merged
merged 3 commits into from
May 3, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 3, 2023

Description

Fix build error on new manager.

--- stderr: behavior_path_planner                                                                                                                                                                                                                                                                                                                                                                                               
CMake Warning at CMakeLists.txt:78 (message):                                                                                                                                                                                                                                                                                                                                                                                   
  Build behavior_path_planner with NEW framework...                                                                                                                                                                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                                                                                                                                                                                                
                                                                                                                                                                                                                                                                                                                                                                                                                                
/home/satoshi/pilot-auto/src/autoware/universe/planning/behavior_path_planner/src/planner_manager.cpp: In lambda function:                                                                                                                                                                                                                                                                                                      
/home/satoshi/pilot-auto/src/autoware/universe/planning/behavior_path_planner/src/planner_manager.cpp:51:7: error: ‘scene_modules_’ was not declared in this scope                                                                                                                                                                                                                                                              
   51 |       scene_modules_.begin(), scene_modules_.end(),                                                                                                                                                                                                                                                                                                                                                                     
      |       ^~~~~~~~~~~~~~                                                                                                                                                                                                                                                                                                                                                                                                    
/home/satoshi/pilot-auto/src/autoware/universe/planning/behavior_path_planner/src/planner_manager.cpp: In lambda function:                                                                                                                                                                                                                                                                                                      
/home/satoshi/pilot-auto/src/autoware/universe/planning/behavior_path_planner/src/planner_manager.cpp:52:70: error: ‘BT’ has not been declared                                                                                                                                                                                                                                                                                  
   52 |       [](const auto & module) { return module->getCurrentStatus() == BT::NodeStatus::RUNNING; });                                                                                                                                                                                                                                                                                                                       
      |                                                                      ^~                                                                                                                                                                                                                                                                                                                                                 
gmake[2]: *** [CMakeFiles/behavior_path_planner_node.dir/build.make:76: CMakeFiles/behavior_path_planner_node.dir/src/planner_manager.cpp.o] Error 1                                                                                                                                                                                                                                                                            
gmake[2]: *** Waiting for unfinished jobs....                                                                                                                                                                                                                                                                                                                                                                                   
gmake[1]: *** [CMakeFiles/Makefile2:186: CMakeFiles/behavior_path_planner_node.dir/all] Error 2                                                                                                                                                                                                                                                                                                                                 
gmake: *** [Makefile:146: all] Error 2                                                                                                                                                                                                                                                                                                                                                                                          
---                                                                                                                                                                                                                                                                                                                                                                                                                             
Failed   <<< behavior_path_planner [3min 16s, exited with code 2]

Tests performed

Build passed in my local pc.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 3, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:bow:

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.87 ⚠️

Comparison is base (ff7c808) 14.59% compared to head (fda95d9) 13.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3611      +/-   ##
==========================================
- Coverage   14.59%   13.73%   -0.87%     
==========================================
  Files        1299     1397      +98     
  Lines       92414    98263    +5849     
  Branches    29238    29238              
==========================================
  Hits        13492    13492              
- Misses      64383    70232    +5849     
  Partials    14539    14539              
Flag Coverage Δ *Carryforward flag
differential 12.39% <ø> (?)
total 13.72% <ø> (-0.87%) ⬇️ Carriedforward from 88a1039

*This pull request uses carry forward flags. Click here to find out more.

see 99 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota enabled auto-merge (squash) May 3, 2023 01:37
@satoshi-ota satoshi-ota merged commit b173491 into autowarefoundation:main May 3, 2023
@satoshi-ota satoshi-ota deleted the fix/build-error branch May 3, 2023 02:39
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
* fix(planner_manager): fix build error

Signed-off-by: satoshi-ota <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

* Update planning/behavior_path_planner/src/planner_manager.cpp

---------

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: Mingyu Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants