Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): terminate turn signal when it passes end point #3631

Merged
merged 1 commit into from
May 8, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented May 8, 2023

Description

Fix turn signal decider to terminate the turn signal when there is intersection turn signal information.

Tests performed

1336/1350
TIER4 Internal Link

Not applicable.

Effects on system behavior

Turn signal ends properly when it reaches at the required end point.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 9.72% and project coverage change: +0.04 🎉

Comparison is base (5440e27) 13.70% compared to head (a36f909) 13.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3631      +/-   ##
==========================================
+ Coverage   13.70%   13.75%   +0.04%     
==========================================
  Files        1397     1399       +2     
  Lines       98279    98173     -106     
  Branches    29269    29198      -71     
==========================================
+ Hits        13474    13506      +32     
+ Misses      70238    70069     -169     
- Partials    14567    14598      +31     
Flag Coverage Δ *Carryforward flag
differential 12.91% <9.72%> (?)
total 13.75% <ø> (+0.04%) ⬆️ Carriedforward from 5440e27

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...viz_plugin/src/velocity_steering_factors_panel.cpp 0.00% <ø> (ø)
...ht_rviz_plugin/src/traffic_light_publish_panel.cpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 75.00% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 10.86% <0.00%> (-0.50%) ⬇️
...ath_planner/scene_module/lane_change/interface.hpp 33.33% <ø> (+24.24%) ⬆️
...r_path_planner/scene_module/lane_change/normal.hpp 100.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 32.83% <0.00%> (+0.26%) ⬆️
.../utils/goal_planner/default_fixed_goal_planner.hpp 100.00% <ø> (+100.00%) ⬆️
...ner/utils/goal_planner/fixed_goal_planner_base.hpp 33.33% <0.00%> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit c46ba35 into main May 8, 2023
@purewater0901 purewater0901 deleted the fix/terminate-turn-signal branch May 8, 2023 06:15
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants