Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): disable safety check #3633

Merged
merged 1 commit into from
May 8, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented May 8, 2023

Description

Currently, the lane change module spends a lot of time to check if the generated candidate path is inside of the lanelets. Even though the generated path is usually in the designated lanelets, it unreasonably takes tons of time. In this PR, I made a flag and disable this safety check for the default setting.

🤖 Generated by Copilot at 9a27ae2

Added a temporary flag to skip a slow path check in utils.cpp. This is to improve the lane change performance of the behavior path planner.

Tests performed

Scenario Test 1324/1350
TIER4 Internal Link

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 11.45% and project coverage change: +0.87 🎉

Comparison is base (850775f) 13.82% compared to head (9a27ae2) 14.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3633      +/-   ##
==========================================
+ Coverage   13.82%   14.70%   +0.87%     
==========================================
  Files        1396     1298      -98     
  Lines       97973    92135    -5838     
  Branches    29110    29114       +4     
==========================================
+ Hits        13548    13550       +2     
+ Misses      69785    63934    -5851     
- Partials    14640    14651      +11     
Flag Coverage Δ *Carryforward flag
differential 12.83% <11.45%> (?)
total 14.71% <ø> (+0.88%) ⬆️ Carriedforward from 850775f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ateral_controller/src/qp_solver/qp_solver_osqp.cpp 44.44% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...clude/behavior_path_planner/utils/safety_check.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.62% <0.00%> (-0.25%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.67% <0.00%> (-0.01%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.81% <0.00%> (+<0.01%) ⬆️
...g/behavior_path_planner/src/utils/safety_check.cpp 0.00% <0.00%> (-5.36%) ⬇️
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <ø> (ø)
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 49.06% <ø> (ø)
... and 7 more

... and 99 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit a89b261 into main May 8, 2023
@purewater0901 purewater0901 deleted the feat/disable-safety-check branch May 8, 2023 09:45
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 25, 2023
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 7, 2023
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants