Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnss_poser): add orthometric height as a option #3740

Merged

Conversation

farukbaykara
Copy link
Contributor

@farukbaykara farukbaykara commented May 17, 2023

Description

  • Added to gnss_poser package as an option to convert ellipsoid height to orthometric height.
  • Added a height_system parameter to gnss_poser.launch and user can select whether use ellipsoid to orthometric height conversion.
  • Output always will be orthometric height.

Closes: #3693

Tests performed

Tested using bag collected from YTU Davutpasa campus with Robione robot.
Will be tested on vehicle too.

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@farukbaykara farukbaykara requested review from YamatoAndo and a team as code owners May 17, 2023 15:37
@farukbaykara farukbaykara self-assigned this May 17, 2023
@farukbaykara farukbaykara added component:localization Vehicle's position determination in its environment. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels May 17, 2023
@github-actions github-actions bot removed the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 17, 2023
@farukbaykara farukbaykara changed the title #3693 feat(gnss_poser): add orthometric height as a option feat(gnss_poser): add orthometric height as a option May 17, 2023
@farukbaykara farukbaykara added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 17, 2023
@github-actions github-actions bot removed the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 18, 2023
Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed "Orthometric Height" and "Ellipsoid Height" using the tutorial dataset.
LGTM!

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2afabd0) 14.46% compared to head (8131ed5) 14.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
- Coverage   14.46%   14.46%   -0.01%     
==========================================
  Files        1432     1432              
  Lines      100864   100872       +8     
  Branches    29779    29779              
==========================================
  Hits        14588    14588              
- Misses      70429    70437       +8     
  Partials    15847    15847              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.46% <ø> (+<0.01%) ⬆️ Carriedforward from 2afabd0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
sensing/gnss_poser/include/gnss_poser/convert.hpp 0.00% <0.00%> (ø)
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YamatoAndo YamatoAndo merged commit f700808 into autowarefoundation:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
Development

Successfully merging this pull request may close these issues.

Adding Orthometric height as an option to the gnss poser package
2 participants