-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnss_poser): add orthometric height as a option #3740
feat(gnss_poser): add orthometric height as a option #3740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed "Orthometric Height" and "Ellipsoid Height" using the tutorial dataset.
LGTM!
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
==========================================
- Coverage 14.46% 14.46% -0.01%
==========================================
Files 1432 1432
Lines 100864 100872 +8
Branches 29779 29779
==========================================
Hits 14588 14588
- Misses 70429 70437 +8
Partials 15847 15847
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Description
Closes: #3693
Tests performed
Tested using bag collected from YTU Davutpasa campus with Robione robot.
Will be tested on vehicle too.
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.