Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_api_specs): change topic depth of route state api and localization state api #3757

Merged
merged 2 commits into from
May 29, 2023

Conversation

yabuta
Copy link
Contributor

@yabuta yabuta commented May 18, 2023

Description

Developer had set the depth to 3 for development, but forgot to change it back, so I will fix it to 1.

Tests performed

Execute below command and check to show one message

  • ros2 topic echo /api/routing/route
  • ros2 topic echo /api/localization/initialization_state

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) labels May 18, 2023
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28 ⚠️

Comparison is base (2ea192b) 14.11% compared to head (b9ad4a1) 13.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3757      +/-   ##
==========================================
- Coverage   14.11%   13.84%   -0.28%     
==========================================
  Files        1438     1533      +95     
  Lines      101482   108458    +6976     
  Branches    27045    31018    +3973     
==========================================
+ Hits        14329    15017     +688     
- Misses      71469    77070    +5601     
- Partials    15684    16371     +687     
Flag Coverage Δ *Carryforward flag
differential 14.09% <ø> (?)
total 14.57% <ø> (+0.45%) ⬆️ Carriedforward from 03ebfc8

*This pull request uses carry forward flags. Click here to find out more.

see 147 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yabuta yabuta merged commit 451b504 into autowarefoundation:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants