Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): enable lane change to accelerate in the lane changing segment #3762

Merged
merged 27 commits into from
May 23, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented May 18, 2023

Description

Currently, the lane change module cannot accelerate the ego velocity while it is on the lane changing segment. With this PR, it can accelerate the ego velocity even when the ego vehicle is on the lane-changing segment.

Launch PR

Related links

Tests performed

Planning Simulators

Scenario Result 1309/1375
TIER IV Internal Link

Notes for reviewers

Interface changes

There are no interface changes with this PR.

Effects on system behavior

If the ego velocity is lower than the road max velocity, the ego vehicle starts to accelerate during the lane change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (7399476) 14.52% compared to head (ed67019) 14.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
+ Coverage   14.52%   14.56%   +0.03%     
==========================================
  Files        1442     1439       -3     
  Lines      101467   102235     +768     
  Branches    30160    30778     +618     
==========================================
+ Hits        14741    14891     +150     
- Misses      70586    71124     +538     
- Partials    16140    16220      +80     
Flag Coverage Δ *Carryforward flag
differential 13.20% <0.00%> (?)
total 14.54% <ø> (+0.01%) ⬆️ Carriedforward from 284779f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 10.52% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 100.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.03% <0.00%> (-0.05%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.02% <0.00%> (-0.09%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.88% <0.00%> (-0.03%) ⬇️
...th_planner/src/utils/path_shifter/path_shifter.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 19.98% <ø> (+3.11%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit b4d467a into main May 23, 2023
@purewater0901 purewater0901 deleted the feat/accelerated-lc branch May 23, 2023 11:47
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…ing segment (autowarefoundation#3762)

* refactor(behavior_path_planner): remove unnecessary prepare segment function

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* feat(lane_change): enable acceleration on the prepare segment

Signed-off-by: yutaka <[email protected]>

* feat(behavior_path_planner): add longitudinal acc to path shifter

Signed-off-by: yutaka <[email protected]>

* feat(lane_change): enable lane change to accelerate

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* udpate

* update

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

---------

Signed-off-by: yutaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants