Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): denoise occlusion by morphology open process #3763

Merged
merged 3 commits into from
May 19, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 18, 2023

Description

Apply morphology opening process to remove small occlusion from the occupancy grid.

Related links

parameter PR: autowarefoundation/autoware_launch#361

Tests performed

Psim

kernel size = 1.0m
image

kernel size = 3.0m:

image

Experiment

without this PR
image

with this PR and kernel_size = 2.5m, noisey occlusion does not appear.
image

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 18, 2023
@soblin soblin changed the title Feat/denoise occlusion feat(intersection): denoise occlusion by morphology open process May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3f63c15) 14.51% compared to head (8ec266e) 14.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3763      +/-   ##
==========================================
- Coverage   14.51%   14.51%   -0.01%     
==========================================
  Files        1439     1439              
  Lines      101307   101312       +5     
  Branches    30061    30064       +3     
==========================================
  Hits        14708    14708              
- Misses      70510    70514       +4     
- Partials    16089    16090       +1     
Flag Coverage Δ *Carryforward flag
differential 10.02% <0.00%> (?)
total 14.51% <ø> (+<0.01%) ⬆️ Carriedforward from 3f63c15

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 19.79% <0.00%> (-0.11%) ⬇️
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 2cd0bcb into autowarefoundation:main May 19, 2023
@soblin soblin deleted the feat/denoise-occlusion branch May 19, 2023 05:05
soblin added a commit to soblin/autoware.universe that referenced this pull request May 23, 2023
…owarefoundation#3763)

* apply morpholgoyEx to occlusion_mask_raw to remove noisy occlusion cell

Signed-off-by: Mamoru Sobue <[email protected]>

* parameterize kernel size

Signed-off-by: Mamoru Sobue <[email protected]>

* remove debug

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 29, 2023
…owarefoundation#3763)

* apply morpholgoyEx to occlusion_mask_raw to remove noisy occlusion cell

Signed-off-by: Mamoru Sobue <[email protected]>

* parameterize kernel size

Signed-off-by: Mamoru Sobue <[email protected]>

* remove debug

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request May 29, 2023
* feat(intersection): denoise occlusion by morphology open process (autowarefoundation#3763)

* apply morpholgoyEx to occlusion_mask_raw to remove noisy occlusion cell

Signed-off-by: Mamoru Sobue <[email protected]>

* parameterize kernel size

Signed-off-by: Mamoru Sobue <[email protected]>

* remove debug

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>

* fix(intersection): add the flag for intersection_occlusion grid publication (autowarefoundation#3844)

Signed-off-by: tomoya.kimura <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Mamoru Sobue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants