Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix keeping terminal point #3813

Merged
merged 1 commit into from
May 25, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 25, 2023

Description

If the difference between s and s_end was exactly epsilon, that point would be missing, but modified to keep it.

Related links

#3720

Tests performed

psim

Notes for reviewers

Interface changes

not applicable

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as ready for review May 25, 2023 02:50
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.04 ⚠️

Comparison is base (98169fe) 14.11% compared to head (1d2d9aa) 14.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
- Coverage   14.11%   14.08%   -0.04%     
==========================================
  Files        1438     1438              
  Lines      101445   101898     +453     
  Branches    27021    27355     +334     
==========================================
+ Hits        14318    14351      +33     
- Misses      71446    71841     +395     
- Partials    15681    15706      +25     
Flag Coverage Δ *Carryforward flag
differential 13.17% <75.00%> (?)
total 14.11% <ø> (-0.01%) ⬇️ Carriedforward from 98169fe

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ing/behavior_path_planner/src/utils/path_utils.cpp 12.88% <75.00%> (+0.78%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit c1de8fd into main May 25, 2023
@kosuke55 kosuke55 deleted the fix/behavior_path_resample branch May 25, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants