Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): remove SUCCESS module candidate path #3929

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 9, 2023

Description

remove SUCCESS module candidate path

Related links

#3928

Tests performed

psim

kepp_running_candidate-2023-06-09_20.40.12.mp4

Notes for reviewers

Interface changes

not applicable

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jun 9, 2023

merge after #3928

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 9, 2023
@kosuke55 kosuke55 force-pushed the feat/remove_sucess_module_candidate_path_marker branch from 6b442fd to bf04915 Compare June 9, 2023 12:12
@kosuke55 kosuke55 force-pushed the feat/remove_sucess_module_candidate_path_marker branch from bf04915 to f11133d Compare June 9, 2023 12:31
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.99 🎉

Comparison is base (21b6403) 14.43% compared to head (f11133d) 15.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3929      +/-   ##
==========================================
+ Coverage   14.43%   15.43%   +0.99%     
==========================================
  Files        1456     1350     -106     
  Lines      102536    95931    -6605     
  Branches    29720    29720              
==========================================
  Hits        14806    14806              
+ Misses      71575    64970    -6605     
  Partials    16155    16155              
Flag Coverage Δ *Carryforward flag
differential 13.04% <0.00%> (?)
total 15.43% <ø> (+0.99%) ⬆️ Carriedforward from 21b6403

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 18.64% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants