Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix root next lanelets check #3995

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 16, 2023

Description

fix root next lanelets check

  • root_lanelet_ is previous one
  • root_lanelet is current one which is calulated from current self pose.
    so, need to check root_lanelet is next lanes of root_lanelet

Related links

Tests performed

psim
tier4_internal_scnenario_tests 1331/1372

Notes for reviewers

none

Interface changes

none

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2465bbf) 14.41% compared to head (9456efc) 14.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3995   +/-   ##
=======================================
  Coverage   14.41%   14.41%           
=======================================
  Files        1456     1456           
  Lines      102765   102765           
  Branches    29787    29787           
=======================================
  Hits        14814    14814           
  Misses      71767    71767           
  Partials    16184    16184           
Flag Coverage Δ *Carryforward flag
differential 12.82% <ø> (?)
total 14.41% <ø> (ø) Carriedforward from 2465bbf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 9c7b44d into main Jun 19, 2023
@kosuke55 kosuke55 deleted the fix/planner_manager_root_next_lanes branch June 19, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants