Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smoother): autonomous driving mode check #4009

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 19, 2023

Description

Autonomous driving mode check was wrong. Fix for this PR: #3948

Tests performed

Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (15325f6) 14.41% compared to head (cda720e) 14.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4009   +/-   ##
=======================================
  Coverage   14.41%   14.41%           
=======================================
  Files        1456     1456           
  Lines      102763   102763           
  Branches    29785    29785           
=======================================
  Hits        14815    14815           
  Misses      71765    71765           
  Partials    16183    16183           
Flag Coverage Δ *Carryforward flag
differential 11.60% <0.00%> (?)
total 14.41% <ø> (+<0.01%) ⬆️ Carriedforward from 15325f6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 28.03% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe enabled auto-merge (squash) June 19, 2023 06:57
@TakaHoribe TakaHoribe merged commit 05566ec into autowarefoundation:main Jun 19, 2023
@TakaHoribe TakaHoribe deleted the fix-smoother-engage-on-manual branch June 19, 2023 07:20
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants