Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): update traffic light launch #4176

Merged

Conversation

Mingyu1991
Copy link
Contributor

Description

  • Add launch for traffic_light_occlusion_predictor
  • Divide the traffic light nodes into classification and detection namespaces.

This PR should not be merged until the following PRs are merged to main:

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mingyu Li <[email protected]>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jul 5, 2023
miursh and others added 6 commits July 8, 2023 00:24
…t_launch

# Conflicts:
#	launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 7, 2023
Signed-off-by: Shunsuke Miura <[email protected]>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (ca37348) 14.25% compared to head (854e71e) 14.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4176      +/-   ##
==========================================
+ Coverage   14.25%   14.33%   +0.07%     
==========================================
  Files        1580     1571       -9     
  Lines      108773   108154     -619     
  Branches    31429    31303     -126     
==========================================
- Hits        15510    15502       -8     
+ Misses      76395    75801     -594     
+ Partials    16868    16851      -17     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.33% <ø> (+0.07%) ⬆️ Carriedforward from f48c857

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ion/traffic_light_multi_camera_fusion/src/node.cpp 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit bc9f62c into autowarefoundation:main Jul 8, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 9, 2023
…oundation#4176)

* first commit

Signed-off-by: Mingyu Li <[email protected]>

* add image number arg

Signed-off-by: Shunsuke Miura <[email protected]>

* style(pre-commit): autofix

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

* add traffic light namespace to fusion

Signed-off-by: Shunsuke Miura <[email protected]>

* add tlr fusion only mode and camera number arg

Signed-off-by: Shunsuke Miura <[email protected]>

* change to include traffic_light_arbiter launch

Signed-off-by: Shunsuke Miura <[email protected]>

* delete relay topic type

Signed-off-by: Shunsuke Miura <[email protected]>

---------

Signed-off-by: Mingyu Li <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <[email protected]>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Jul 28, 2023
…oundation#4176)

* first commit

Signed-off-by: Mingyu Li <[email protected]>

* add image number arg

Signed-off-by: Shunsuke Miura <[email protected]>

* style(pre-commit): autofix

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

* add traffic light namespace to fusion

Signed-off-by: Shunsuke Miura <[email protected]>

* add tlr fusion only mode and camera number arg

Signed-off-by: Shunsuke Miura <[email protected]>

* change to include traffic_light_arbiter launch

Signed-off-by: Shunsuke Miura <[email protected]>

* delete relay topic type

Signed-off-by: Shunsuke Miura <[email protected]>

---------

Signed-off-by: Mingyu Li <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
Development

Successfully merging this pull request may close these issues.

2 participants