-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): update traffic light launch #4176
feat(tier4_perception_launch): update traffic light launch #4176
Conversation
Signed-off-by: Mingyu Li <[email protected]>
...r4_perception_launch/launch/traffic_light_recognition/traffic_light_node_container.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Shunsuke Miura <[email protected]>
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
…n/traffic_light.launch.xml
…n/traffic_light.launch.xml
Signed-off-by: Shunsuke Miura <[email protected]>
…t_launch # Conflicts: # launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4176 +/- ##
==========================================
+ Coverage 14.25% 14.33% +0.07%
==========================================
Files 1580 1571 -9
Lines 108773 108154 -619
Branches 31429 31303 -126
==========================================
- Hits 15510 15502 -8
+ Misses 76395 75801 -594
+ Partials 16868 16851 -17
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oundation#4176) * first commit Signed-off-by: Mingyu Li <[email protected]> * add image number arg Signed-off-by: Shunsuke Miura <[email protected]> * style(pre-commit): autofix * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * add traffic light namespace to fusion Signed-off-by: Shunsuke Miura <[email protected]> * add tlr fusion only mode and camera number arg Signed-off-by: Shunsuke Miura <[email protected]> * change to include traffic_light_arbiter launch Signed-off-by: Shunsuke Miura <[email protected]> * delete relay topic type Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]> Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <[email protected]>
…oundation#4176) * first commit Signed-off-by: Mingyu Li <[email protected]> * add image number arg Signed-off-by: Shunsuke Miura <[email protected]> * style(pre-commit): autofix * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * add traffic light namespace to fusion Signed-off-by: Shunsuke Miura <[email protected]> * add tlr fusion only mode and camera number arg Signed-off-by: Shunsuke Miura <[email protected]> * change to include traffic_light_arbiter launch Signed-off-by: Shunsuke Miura <[email protected]> * delete relay topic type Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]> Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <[email protected]>
Description
This PR should not be merged until the following PRs are merged to main:
Tests performed
Nothing.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.