Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(traffic_light): cherry pick traffic light launcher updates #692

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Jul 28, 2023

Description

cherry-pick following PR to beta/v0.9.0

Tests performed

I confirmed necessary nodes are launched when fusion_only is set to true.

❯ ros2 node list | grep traffic
/autoware_api/internal/traffic_signals
/awapi/nearest_traffic_signal_relay
/awapi/overwrite_traffic_signals_relay
/awapi/traffic_signal_relay
/perception/traffic_light_recognition/camera6/classification/traffic_light_occlusion_predictor
/perception/traffic_light_recognition/camera6/classification/transform_listener_impl_55df7cba5c08
/perception/traffic_light_recognition/traffic_light_arbiter/arbiter
/perception/traffic_light_recognition/traffic_light_arbiter/container
/perception/traffic_light_recognition/traffic_light_map_visualizer
/perception/traffic_light_recognition/traffic_light_multi_camera_fusion

image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Mingyu1991 and others added 2 commits July 28, 2023 11:43
…oundation#4176)

* first commit

Signed-off-by: Mingyu Li <[email protected]>

* add image number arg

Signed-off-by: Shunsuke Miura <[email protected]>

* style(pre-commit): autofix

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

* add traffic light namespace to fusion

Signed-off-by: Shunsuke Miura <[email protected]>

* add tlr fusion only mode and camera number arg

Signed-off-by: Shunsuke Miura <[email protected]>

* change to include traffic_light_arbiter launch

Signed-off-by: Shunsuke Miura <[email protected]>

* delete relay topic type

Signed-off-by: Shunsuke Miura <[email protected]>

---------

Signed-off-by: Mingyu Li <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <[email protected]>
…ation#4393)

* fix(traffic_light): fix traffic_light_arbiter pipeline

Signed-off-by: 1222-takeshi <[email protected]>

* style(pre-commit): autofix

* fix: output topic name

Signed-off-by: 1222-takeshi <[email protected]>

---------

Signed-off-by: 1222-takeshi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit f79a59b into beta/v0.9.0 Aug 1, 2023
12 of 13 checks passed
@TomohitoAndo TomohitoAndo deleted the cherry-pick-traffic-light-launcher branch August 1, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants