feat(routing_no_drivable_lane_when_module_enabled): add solution for routing no_drivable_lane only when module enabled #4308
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jul 31, 2023 in 41s
CodeScene PR Check
❌ Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method route_handler.cpp: RouteHandler::planPathLaneletsBetweenCheckpoints
Annotations
Check notice on line 1 in planning/route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1800 to 1804, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 2053 in planning/route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
RouteHandler::planPathLaneletsBetweenCheckpoints increases in cyclomatic complexity from 11 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.40 to 4.41, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading