feat(routing_no_drivable_lane_when_module_enabled): add solution for routing no_drivable_lane only when module enabled #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmeddesokyebrahim
added
the
component:planning
ahmeddesokyebrahim
requested review from
rej55,
kosuke55,
purewater0901,
zulfaqar-azmi-t4,
isamu-takagi,
mitsudome-r,
TakaHoribe,
takayuki5168,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
type:documentation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
==========================================
- Coverage 14.91% 14.90% -0.01%
==========================================
Files 1520 1517 -3
Lines 104738 104784 +46
Branches 31884 31939 +55
==========================================
+ Hits 15619 15623 +4
- Misses 72067 72107 +40
- Partials 17052 17054 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4307-routing-no-drivable-lane-when-module-enabled
branch
from
6352c86
to
5716604
Compare
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4307-routing-no-drivable-lane-when-module-enabled
branch
3 times, most recently
from
1eb35c6
to
c77750b
Compare
mehmetdogru
added
the
tag:run-build-and-test-differential
…tion Signed-off-by: AhmedEbrahim <[email protected]>
…s regarding new parameter Signed-off-by: AhmedEbrahim <[email protected]>
…anged by mistake Signed-off-by: AhmedEbrahim <[email protected]>
ahmeddesokyebrahim
force-pushed
the
autoware/universe/4307-routing-no-drivable-lane-when-module-enabled
branch
from
c77750b
to
0eac8f6
Compare
mehmetdogru
added
tag:run-build-and-test-differential
|
@ahmeddesokyebrahim CC: @mehmetdogru |
zulfaqar-azmi-t4
approved these changes
Aug 7, 2023
takayuki5168
approved these changes
Aug 7, 2023
ahmeddesokyebrahim
deleted the
autoware/universe/4307-routing-no-drivable-lane-when-module-enabled
branch
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…routing no_drivable_lane only when module enabled (autowarefoundation#4308) * feat(routing_no_drivable_lane_when_module_enabled): add proposed solution Signed-off-by: AhmedEbrahim <[email protected]> * feat(routing_no_drivable_lane_when_module_enabled): improving comments regarding new parameter Signed-off-by: AhmedEbrahim <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * feat(routing_no_drivable_lane_when_module_enabled): reverting file changed by mistake Signed-off-by: AhmedEbrahim <[email protected]> --------- Signed-off-by: AhmedEbrahim <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add as solution for routing
no_drivable_lane(s)only when the module is enabled.Related links
fixes #4307
Tests performed
Using planning simulator :
no_drivable_laneis disabled, the routing forno_drivable_lane(s)is not consideredno_drivable_laneis enabled, routing forno_drivable_lane(s)is consideredNotes for reviewers
❗ Must be merged with this autoware_launch PR ❗
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.