-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(routing_no_drivable_lane_when_module_enabled): add solution for routing no_drivable_lane only when module enabled #4308
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
==========================================
- Coverage 14.91% 14.90% -0.01%
==========================================
Files 1520 1517 -3
Lines 104738 104784 +46
Branches 31884 31939 +55
==========================================
+ Hits 15619 15623 +4
- Misses 72067 72107 +40
- Partials 17052 17054 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6352c86
to
5716604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
1eb35c6
to
c77750b
Compare
…tion Signed-off-by: AhmedEbrahim <[email protected]>
…s regarding new parameter Signed-off-by: AhmedEbrahim <[email protected]>
…anged by mistake Signed-off-by: AhmedEbrahim <[email protected]>
c77750b
to
0eac8f6
Compare
@ahmeddesokyebrahim CC: @mehmetdogru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Confirmed with TIER IV scenarios 1582/1588
…routing no_drivable_lane only when module enabled (autowarefoundation#4308) * feat(routing_no_drivable_lane_when_module_enabled): add proposed solution Signed-off-by: AhmedEbrahim <[email protected]> * feat(routing_no_drivable_lane_when_module_enabled): improving comments regarding new parameter Signed-off-by: AhmedEbrahim <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * feat(routing_no_drivable_lane_when_module_enabled): reverting file changed by mistake Signed-off-by: AhmedEbrahim <[email protected]> --------- Signed-off-by: AhmedEbrahim <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
This PR is to add as solution for routing
no_drivable_lane(s)
only when the module is enabled.Related links
fixes #4307
Tests performed
Using planning simulator :
no_drivable_lane
is disabled, the routing forno_drivable_lane(s)
is not consideredno_drivable_lane
is enabled, routing forno_drivable_lane(s)
is consideredNotes for reviewers
❗ Must be merged with this autoware_launch PR ❗
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.