Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(detected_object_validation): add an option for filtering and validation #4402

Merged

Conversation

ismetatabay
Copy link
Member

@ismetatabay ismetatabay commented Jul 26, 2023

Description

This PR adds an option for using object_lanelet_filter or object_position_filter as an filtering option and using obstacle_pointcloud or occupancy_grid as an validating option. Moreover, at the latest version of autoware.universe, we cannot launch occupancy_grid map for validator properly, this PR fixes this issue also.

Related links

Tests performed

The tests are performed in logging simulator: object_lanelet_filter, object_position_filter, obstacle_pointcloud and occupancy_grid (we need change occupancy_grid_map_method to laserscan_based_occupancy_grid_map also) mode works as expected.

Notes for reviewers

Interface changes

These PRs adds detected_objects_filter_method and detected_objects_validation_method arguments to perception component launches.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 26, 2023
@ismetatabay ismetatabay marked this pull request as ready for review July 26, 2023 14:00
Signed-off-by: ismetatabay <[email protected]>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismetatabay
Copy link
Member Author

@yukkysaito Hi, could you check it? Miura-san approved it 👍

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 👍
LGTM

@yukkysaito yukkysaito added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (c889d94) 14.84% compared to head (4dcdb19) 14.90%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4402      +/-   ##
==========================================
+ Coverage   14.84%   14.90%   +0.06%     
==========================================
  Files        1521     1519       -2     
  Lines      105287   104788     -499     
  Branches    32058    31856     -202     
==========================================
- Hits        15629    15623       -6     
+ Misses      72588    72103     -485     
+ Partials    17070    17062       -8     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.90% <ø> (+0.06%) ⬆️ Carriedforward from 0a1c686

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 14.28% <ø> (ø)
...ath_planner/scene_module/lane_change/interface.hpp 100.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 18.60% <ø> (+2.07%) ⬆️
...nner/scene_module/side_shift/side_shift_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
...ning/behavior_path_planner/src/planner_manager.cpp 19.57% <ø> (+0.06%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.18% <ø> (+0.41%) ⬆️
...planner/src/scene_module/lane_change/interface.cpp 6.30% <ø> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ismetatabay ismetatabay merged commit eba0e27 into autowarefoundation:main Aug 7, 2023
22 of 23 checks passed
@ismetatabay ismetatabay deleted the refactor/object_validation branch August 7, 2023 09:57
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
… validation (autowarefoundation#4402)

* init commit

Signed-off-by: ismetatabay <[email protected]>

* update occupancy_grid_map path

Signed-off-by: ismetatabay <[email protected]>

* update argument names

Signed-off-by: ismetatabay <[email protected]>

* correct radar launch objects_filter_method name

Signed-off-by: ismetatabay <[email protected]>

* remove radar option

Signed-off-by: ismetatabay <[email protected]>

---------

Signed-off-by: ismetatabay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants