-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_launch): add an option for filtering and validation #479
Merged
ismetatabay
merged 5 commits into
autowarefoundation:main
from
ismetatabay:detected_object_validation
Aug 7, 2023
Merged
refactor(autoware_launch): add an option for filtering and validation #479
ismetatabay
merged 5 commits into
autowarefoundation:main
from
ismetatabay:detected_object_validation
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
changed the title
refactor(autoware_launch): add an option to perception for filtering and validation
refactor(autoware_launch): add an option for filtering and validation
Aug 4, 2023
ismetatabay
changed the title
refactor(autoware_launch): add an option for filtering and validation
refactor(autoware_launch): add an option for filtering and validation
Aug 4, 2023
Hi, could you also check it @yukkysaito 👍 ? |
yukkysaito
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Looks Good!
This was referenced Aug 8, 2023
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 3, 2023
ci: add backport.yaml to sync-files.yaml (#477) (cherry picked from commit cf775a6) Co-authored-by: Hiroki OTA <[email protected]>
rej55
pushed a commit
to rej55/autoware_launch
that referenced
this pull request
Jul 10, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option which determines object filtering and object validation method to tier4_perception_component.
releated:
autoware.universe PR:
Tests performed
The tests are performed in logging simulator: object_lanelet_filter, object_position_filter, obstacle_pointcloud and occupancy_grid (we need change occupancy_grid_map_method to laserscan_based_occupancy_grid_map also) mode works as expected.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.