Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_launch): add an option for filtering and validation #479

Merged

Conversation

ismetatabay
Copy link
Member

Description

This PR adds an option which determines object filtering and object validation method to tier4_perception_component.

releated:

autoware.universe PR:

Tests performed

The tests are performed in logging simulator: object_lanelet_filter, object_position_filter, obstacle_pointcloud and occupancy_grid (we need change occupancy_grid_map_method to laserscan_based_occupancy_grid_map also) mode works as expected.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay marked this pull request as ready for review July 26, 2023 14:00
@ismetatabay ismetatabay changed the title refactor(autoware_launch): add an option to perception for filtering and validation refactor(autoware_launch): add an option for filtering and validation Aug 4, 2023
@ismetatabay ismetatabay changed the title refactor(autoware_launch): add an option for filtering and validation refactor(autoware_launch): add an option for filtering and validation Aug 4, 2023
@ismetatabay
Copy link
Member Author

Hi, could you also check it @yukkysaito 👍 ?

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍
Looks Good!

@ismetatabay ismetatabay merged commit 75eb848 into autowarefoundation:main Aug 7, 2023
8 of 9 checks passed
@ismetatabay ismetatabay deleted the detected_object_validation branch August 7, 2023 09:57
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
ci: add backport.yaml to sync-files.yaml (#477)

(cherry picked from commit cf775a6)

Co-authored-by: Hiroki OTA <[email protected]>
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants