Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): change skip updataData() process condition #4573

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Aug 8, 2023

Description

The original motivation of skipping updateData() when module is not running is the other process were not necessary.
But when IDLE status is introduced, condition of not runnnig module is changed from running to running || idle.
So in this PR, skip condition is changed.

TODO(In other PR)

  • refactor
  • adapat new interface

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 12, 2023
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review August 12, 2023 17:54
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (58d8e8e) 14.83% compared to head (0b41f5c) 14.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4573      +/-   ##
==========================================
- Coverage   14.83%   14.80%   -0.03%     
==========================================
  Files        1529     1527       -2     
  Lines      105799   105646     -153     
  Branches    32240    32123     -117     
==========================================
- Hits        15698    15644      -54     
+ Misses      72943    72902      -41     
+ Partials    17158    17100      -58     
Flag Coverage Δ *Carryforward flag
differential 13.25% <0.00%> (?)
total 14.77% <ø> (-0.07%) ⬇️ Carriedforward from 7502305

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../src/scene_module/side_shift/side_shift_module.cpp 12.09% <0.00%> (+6.51%) ⬆️
...clude/obstacle_avoidance_planner/mpt_optimizer.hpp 85.71% <ø> (ø)
...cle_avoidance_planner/state_equation_generator.hpp 100.00% <ø> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 39.71% <ø> (-0.29%) ⬇️
...avoidance_planner/src/state_equation_generator.cpp 54.54% <ø> (-14.43%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit e8dd225 into autowarefoundation:main Aug 14, 2023
33 of 38 checks passed
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 21, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the fix/side_shift_no_skip_when_idle branch July 22, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants