-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): change skip updataData() process condition #4573
fix(behavior_path_planner): change skip updataData() process condition #4573
Conversation
Signed-off-by: kyoichi-sugahara <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4573 +/- ##
==========================================
- Coverage 14.83% 14.80% -0.03%
==========================================
Files 1529 1527 -2
Lines 105799 105646 -153
Branches 32240 32123 -117
==========================================
- Hits 15698 15644 -54
+ Misses 72943 72902 -41
+ Partials 17158 17100 -58
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e8dd225
into
autowarefoundation:main
autowarefoundation#4573) change skip condition Signed-off-by: kyoichi-sugahara <[email protected]>
autowarefoundation#4573) change skip condition Signed-off-by: kyoichi-sugahara <[email protected]>
Description
The original motivation of skipping updateData() when module is not running is the other process were not necessary.
But when
IDLE
status is introduced, condition of not runnnig module is changed fromrunning
torunning
||idle
.So in this PR, skip condition is changed.
TODO(In other PR)
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.