Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: change map_projector_type topic name #4582

Closed
wants to merge 57 commits into from
Closed

feat!: change map_projector_type topic name #4582

wants to merge 57 commits into from

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 10, 2023 •
edited
Loading

Will be open after #3986 is merged:

Description

Change the name of the topic /map/map_projector_type, since it mismatches with the type of the topic MapProjectorInfo.

Related links

N/A

Tests performed

TO BE FILLED

Notes for reviewers

N/A

Interface changes

Yes
/map/map_projector_type will be renamed to /map/map_projector_info

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 30 commits June 15, 2023 19:18
@kminoda
feat(map_projection_loader): add map_projection_loader
d88ddd5 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
b8b98aa
@kminoda
Update default algorithm
c3bbd3d 
Signed-off-by: kminoda <[email protected]>
@kminoda
fix test
1fa4347 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
37f9619
@kminoda
add readme
a6ac915 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
7c1b2d1
@kminoda
Merge branch 'main' into feat/add_map_projection_loader
7224aaa
@kminoda
fix launch file and fix map_loader
e1f3738 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
1c4fa44
@kminoda
update lanelet2
3257cf5 
Signed-off-by: kminoda <[email protected]>
@kminoda
fill yaml file path
7973c97 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
b7175a0
@kminoda
update readme
1d3e8c2 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
046dc11
@kminoda
minor fix
9a89f2f 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
4fb2ceb
@kminoda
fix test
331ced7 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
a439d6c
@kminoda
add include guard
02c3c1d 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
4aea876
@kminoda
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
c456cf1 
…ader
@kminoda
update test
f2d407d 
Signed-off-by: kminoda <[email protected]>
@kminoda
update map_loader
7621554 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
085afcb
@kminoda
update docs
7c849fc
@pre-commit-ci
style(pre-commit): autofix
d32d01a
@kminoda
update
53f6c92 
Signed-off-by: kminoda <[email protected]>
@kminoda
add dependency
604fc25 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
aab3325
kminoda and others added 23 commits August 2, 2023 18:32
@kminoda
update test
108d7fc 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
2727ecc
@kminoda
add url
6817598 
Signed-off-by: kminoda <[email protected]>
@kminoda
enable python tests
73e45b3 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
2f7fca1
@kminoda
small fix
e41bd9a 
Signed-off-by: kminoda <[email protected]>
@kminoda
fix grammar
d365f2a 
Signed-off-by: kminoda <[email protected]>
@kminoda
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
c0190e4 
…ader
@kminoda
remove transverse mercator
87ae213 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
9d87a53
@kminoda
add rule in map
7097b2d 
Signed-off-by: kminoda <[email protected]>
@kminoda
fix readme of map loader
4b8ddbb 
Signed-off-by: kminoda <[email protected]>
@kminoda
remove transverse mercator for now
7d56305 
Signed-off-by: kminoda <[email protected]>
@kminoda
add utm
b358ab9 
Signed-off-by: kminoda <[email protected]>
@kminoda
remove altitude from current projection loader
ea735e2 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
08b6ded
@kminoda
fix pre-commit
081cc0b 
Signed-off-by: kminoda <[email protected]>
@kminoda
fix build error
0702af6 
Signed-off-by: kminoda <[email protected]>
@kminoda
fix: remove package.xml
378d9dc 
Signed-off-by: kminoda <[email protected]>
@kminoda
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
f008839 
…ader
@kminoda
fix clang-tidy
0509fe1 
Signed-off-by: kminoda <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
05cf612
@kminoda
feat!: change map_projector_type topic name
97b7ab4 
Signed-off-by: kminoda <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 10, 2023
@kminoda
resolve conflict
c64261b 
Signed-off-by: kminoda <[email protected]>
@kminoda kminoda closed this Aug 10, 2023
@kminoda kminoda deleted the feat/change_map_projector_type_topic_name branch August 10, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 will be requested when the pull request is marked ready for review anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi will be requested when the pull request is marked ready for review KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san will be requested when the pull request is marked ready for review Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto will be requested when the pull request is marked ready for review RyuYamamoto is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro will be requested when the pull request is marked ready for review SakodaShintaro is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 will be requested when the pull request is marked ready for review TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo will be requested when the pull request is marked ready for review YamatoAndo is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi will be requested when the pull request is marked ready for review isamu-takagi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kminoda