Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change map_projector_type topic name #4582

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
d88ddd5
feat(map_projection_loader): add map_projection_loader
kminoda Jun 15, 2023
b8b98aa
style(pre-commit): autofix
pre-commit-ci[bot] Jun 15, 2023
c3bbd3d
Update default algorithm
kminoda Jun 16, 2023
1fa4347
fix test
kminoda Jun 16, 2023
37f9619
style(pre-commit): autofix
pre-commit-ci[bot] Jun 16, 2023
a6ac915
add readme
kminoda Jun 16, 2023
7c1b2d1
style(pre-commit): autofix
pre-commit-ci[bot] Jun 16, 2023
7224aaa
Merge branch 'main' into feat/add_map_projection_loader
kminoda Jul 20, 2023
e1f3738
fix launch file and fix map_loader
kminoda Jul 20, 2023
1c4fa44
style(pre-commit): autofix
pre-commit-ci[bot] Jul 20, 2023
3257cf5
update lanelet2
kminoda Jul 20, 2023
7973c97
fill yaml file path
kminoda Jul 20, 2023
b7175a0
style(pre-commit): autofix
pre-commit-ci[bot] Jul 20, 2023
1d3e8c2
update readme
kminoda Jul 20, 2023
046dc11
style(pre-commit): autofix
pre-commit-ci[bot] Jul 20, 2023
9a89f2f
minor fix
kminoda Jul 24, 2023
4fb2ceb
style(pre-commit): autofix
pre-commit-ci[bot] Jul 24, 2023
331ced7
fix test
kminoda Jul 24, 2023
a439d6c
style(pre-commit): autofix
pre-commit-ci[bot] Jul 24, 2023
02c3c1d
add include guard
kminoda Jul 24, 2023
4aea876
style(pre-commit): autofix
pre-commit-ci[bot] Jul 24, 2023
c456cf1
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
kminoda Jul 24, 2023
f2d407d
update test
kminoda Jul 27, 2023
7621554
update map_loader
kminoda Jul 27, 2023
085afcb
style(pre-commit): autofix
pre-commit-ci[bot] Jul 27, 2023
7c849fc
update docs
kminoda Jul 27, 2023
d32d01a
style(pre-commit): autofix
pre-commit-ci[bot] Jul 27, 2023
53f6c92
update
kminoda Jul 27, 2023
604fc25
add dependency
kminoda Jul 28, 2023
aab3325
style(pre-commit): autofix
pre-commit-ci[bot] Jul 28, 2023
412a640
remove unnecessary parameter
kminoda Jul 28, 2023
a81499d
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
kminoda Aug 2, 2023
c5b1a50
update
kminoda Aug 2, 2023
108d7fc
update test
kminoda Aug 2, 2023
2727ecc
style(pre-commit): autofix
pre-commit-ci[bot] Aug 2, 2023
6817598
add url
kminoda Aug 2, 2023
73e45b3
enable python tests
kminoda Aug 2, 2023
2f7fca1
style(pre-commit): autofix
pre-commit-ci[bot] Aug 2, 2023
e41bd9a
small fix
kminoda Aug 2, 2023
d365f2a
fix grammar
kminoda Aug 2, 2023
c0190e4
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
kminoda Aug 3, 2023
87ae213
remove transverse mercator
kminoda Aug 3, 2023
9d87a53
style(pre-commit): autofix
pre-commit-ci[bot] Aug 3, 2023
7097b2d
add rule in map
kminoda Aug 4, 2023
4b8ddbb
fix readme of map loader
kminoda Aug 4, 2023
7d56305
remove transverse mercator for now
kminoda Aug 4, 2023
b358ab9
add utm
kminoda Aug 4, 2023
ea735e2
remove altitude from current projection loader
kminoda Aug 4, 2023
08b6ded
style(pre-commit): autofix
pre-commit-ci[bot] Aug 4, 2023
081cc0b
fix pre-commit
kminoda Aug 7, 2023
0702af6
fix build error
kminoda Aug 7, 2023
378d9dc
fix: remove package.xml
kminoda Aug 7, 2023
f008839
Merge remote-tracking branch 'origin' into feat/add_map_projection_lo…
kminoda Aug 9, 2023
0509fe1
fix clang-tidy
kminoda Aug 9, 2023
05cf612
style(pre-commit): autofix
pre-commit-ci[bot] Aug 9, 2023
97b7ab4
feat!: change map_projector_type topic name
kminoda Aug 10, 2023
c64261b
resolve conflict
kminoda Aug 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace map_interface
struct MapProjectorInfo
{
using Message = tier4_map_msgs::msg::MapProjectorInfo;
static constexpr char name[] = "/map/map_projector_type";
static constexpr char name[] = "/map/map_projector_info";
static constexpr size_t depth = 1;
static constexpr auto reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE;
static constexpr auto durability = RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL;
Expand Down
2 changes: 1 addition & 1 deletion launch/tier4_map_launch/launch/map.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def launch_setup(context, *args, **kwargs):
name="lanelet2_map_loader",
remappings=[
("output/lanelet2_map", "vector_map"),
("input/map_projector_info", "map_projector_type"),
("input/map_projector_info", "map_projector_info"),
],
parameters=[
{
Expand Down
2 changes: 1 addition & 1 deletion map/map_loader/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ Please see [the description of `GetSelectedPointCloudMap.srv`](https://github.co
### Feature

lanelet2_map_loader loads Lanelet2 file and publishes the map data as autoware_auto_mapping_msgs/HADMapBin message.
The node projects lan/lon coordinates into arbitrary coordinates defined in `/map/map_projector_type` from `map_projection_loader`.
The node projects lan/lon coordinates into arbitrary coordinates defined in `/map/map_projector_info` from `map_projection_loader`.
The node supports the following three types of coordinate systems:

- MGRS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Lanelet2MapLoaderNode : public rclcpp::Node
private:
void on_map_projector_info(const MapProjectorInfo::ConstSharedPtr msg);

rclcpp::Subscription<MapProjectorInfo>::SharedPtr sub_map_projector_type_;
rclcpp::Subscription<MapProjectorInfo>::SharedPtr sub_map_projector_info_;
rclcpp::Publisher<HADMapBin>::SharedPtr pub_map_bin_;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Lanelet2MapLoaderNode::Lanelet2MapLoaderNode(const rclcpp::NodeOptions & options
: Node("lanelet2_map_loader", options)
{
// subscription
sub_map_projector_type_ = create_subscription<MapProjectorInfo>(
sub_map_projector_info_ = create_subscription<MapProjectorInfo>(
"input/map_projector_info", rclcpp::QoS{1}.transient_local(),
[this](const MapProjectorInfo::ConstSharedPtr msg) { on_map_projector_info(msg); });
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<arg name="lanelet2_map_path" description="Path to the lanelet2 map file"/>

<node pkg="map_projection_loader" exec="map_projection_loader" name="map_projection_loader" output="screen">
<remap from="~/map_projector_info" to="/map/map_projector_type"/>
<remap from="~/map_projector_info" to="/map/map_projector_info"/>
<param name="map_projector_info_path" value="$(var map_projector_info_path)"/>
<param name="lanelet2_map_path" value="$(var lanelet2_map_path)"/>
</node>
Expand Down
Loading