Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename map_projector_type to map_projector_info #4664

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 18, 2023

Description

I'd like to rename /map/map_projector_type to /map/map_projector_info.

Reasons:

  • The type of the topic is tier4_map_msgs/msg/MapProjectorInfo which is a little bit different from the topic name. This inconsistency may confuse developers in the near future that may lead to a potential bugs.
  • The topic is relatively new and only used in few modules at this moment. Thus, the cost of change is acceptable.

Related links

TIER IV INTERNAL LINK

Tests performed

  • Launch logging_simulator and ...
    • Run ros2 topic info -v /map/map_projector_type before this PR and ros2 topic info -v /map/map_projector_info after this PR, and confirmed that both matches the same.
    • Run sample rosbag from Autoware Tutorial and confirmed that the system works the same (without any failure in pose initialization, etc)
  • Launch planning_simulator and ...
    • Run ros2 topic info -v /map/map_projector_type before this PR and ros2 topic info -v /map/map_projector_info after this PR, and confirmed that both matches the same.
    • Put initial pose and goal pose, engaged the vehicle, and confirmed that that the system works the same before and after the PR.

Notes for reviewers

N/A

Interface changes

Yes. The topic name has been changed.

Effects on system behavior

No effect expected

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 18, 2023
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 18, 2023
@kminoda kminoda marked this pull request as ready for review August 18, 2023 06:53
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (338d4b0) 14.89% compared to head (f9a5389) 14.89%.
Report is 4 commits behind head on main.

❗ Current head f9a5389 differs from pull request most recent head 1300527. Consider uploading reports for the commit 1300527 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4664    +/-   ##
========================================
  Coverage   14.89%   14.89%            
========================================
  Files        1549     1548     -1     
  Lines      106946   106770   -176     
  Branches    32784    32682   -102     
========================================
- Hits        15926    15900    -26     
+ Misses      73627    73555    -72     
+ Partials    17393    17315    -78     
Flag Coverage Δ *Carryforward flag
differential 15.63% <ø> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from 25355b5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 9.25% <ø> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that the topic was output properly.

LGTM

@kminoda kminoda merged commit 93b00e4 into autowarefoundation:main Aug 21, 2023
16 of 17 checks passed
@kminoda kminoda deleted the feat/rename_map_projector_type branch August 23, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants