-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compare_map_segmentation): fix process died for invalid access #4676
fix(compare_map_segmentation): fix process died for invalid access #4676
Conversation
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
perception/compare_map_segmentation/include/compare_map_segmentation/voxel_grid_map_loader.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: 1222-takeshi <[email protected]>
WalkthroughThe overall change introduces a validity check for the Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (1)
- perception/compare_map_segmentation/include/compare_map_segmentation/voxel_grid_map_loader.hpp (1)
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitai
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignore
anywhere in the PR description to pause further reviews from the bot.
perception/compare_map_segmentation/include/compare_map_segmentation/voxel_grid_map_loader.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: 1222-takeshi <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
=======================================
Coverage 14.89% 14.89%
=======================================
Files 1549 1549
Lines 106946 106944 -2
Branches 32784 32782 -2
=======================================
Hits 15926 15926
+ Misses 73627 73625 -2
Partials 17393 17393
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1222-takeshi thank you for your PR. It LGTM. I will check the reason why index is potential to become negative and fix it soon.
…utowarefoundation#4676) * fix(compare_map_segmentation): fix process died for invalid access Signed-off-by: 1222-takeshi <[email protected]> * style(pre-commit): autofix * fix: missing username in TODO Signed-off-by: 1222-takeshi <[email protected]> * fix: change condition Signed-off-by: 1222-takeshi <[email protected]> * fix Signed-off-by: 1222-takeshi <[email protected]> --------- Signed-off-by: 1222-takeshi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…towarefoundation#4676 (#753) fix(compare_map_segmentation): fix process died for invalid access (autowarefoundation#4676) * fix(compare_map_segmentation): fix process died for invalid access * style(pre-commit): autofix * fix: missing username in TODO * fix: change condition * fix --------- Signed-off-by: 1222-takeshi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
🤖 Generated by Copilot at f811784
Fix a potential bug in
compare_map_segmentation
that could cause out-of-bounds access to a vector. Add a validity check for the index variable invoxel_grid_map_loader.hpp
.Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.
Summary by CodeRabbit
Release Notes:
index
variable in theVoxelGridDynamicMapLoader
class to prevent updating the array with an invalid index.