Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity,behavior_path,route_handler): use route handler in behavior velocity #472

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 3, 2022

Related Issue(required)

#361

Description(required)

  • use setMap function in behavior velocity
  • some functions in route handler will be used in occlusion spot at another PR(add detail later).

Review Procedure(required)

launch psim and see each modules works the same as before

Screenshot from 2022-03-03 12-57-29

@yukkysaito please 👍 if this change looks good

Related PR(optional)

  • release note

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@takayuki5168
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #472 (6d48465) into main (6ded065) will decrease coverage by 8.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #472      +/-   ##
=========================================
- Coverage   11.00%   2.89%   -8.11%     
=========================================
  Files         704     110     -594     
  Lines       49459   10562   -38897     
  Branches     6647     667    -5980     
=========================================
- Hits         5442     306    -5136     
+ Misses      39657   10112   -29545     
+ Partials     4360     144    -4216     
Impacted Files Coverage Δ
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...include/behavior_velocity_planner/planner_data.hpp 0.00% <ø> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/blind_spot/manager.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
...locity_planner/src/scene_module/crosswalk/util.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/detection_area/manager.cpp 0.00% <0.00%> (ø)
... and 607 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ded065...6d48465. Read the comment docs.

@taikitanaka3 taikitanaka3 marked this pull request as ready for review March 3, 2022 05:32
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the simulation runs.
LGTM.

@taikitanaka3 taikitanaka3 merged commit eb8015b into autowarefoundation:main Mar 4, 2022
@taikitanaka3 taikitanaka3 deleted the 361-use-route-handler-in-behavior-velocity branch April 13, 2022 09:54
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
…r in behavior velocity (autowarefoundation#472)

* feat(route_handler): add getter for routing graphs

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): add pkg and remove unused

Signed-off-by: tanaka3 <[email protected]>

* feat(behavior_velocity): add route handler and repalce lanelet map

Signed-off-by: tanaka3 <[email protected]>

* feat(behavior_velocity): replace routing graph

Signed-off-by: tanaka3 <[email protected]>

* feat(behavior_velocity): replace overall graph to route handlers

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): remove remainings

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): refactor for readability

Signed-off-by: tanaka3 <[email protected]>

* chore(behavavior_path): refactor use safe return

Signed-off-by: tanaka3 <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
…lator (#446) (#472)

chore(system_error_monitor): stop to sync parameter for planning_simulator
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
…efoundation#472)

* fix(dummy_perception_publisher): fix build warning in Humble

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants