Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): no stop decision with braking distance #4802

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 29, 2023

Description

Depends on #4781

Added a braking distance calculated by current velocity/acceleration and limitation of acceleration/jerk to the pass judge line added by the following PR.
#4492

Tests performed

scenario simulator
https://evaluation.tier4.jp/evaluation/reports/54768bcb-5b11-5c3e-99fb-b39bcb4378be?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/ffe1d1f7-ea22-5ad1-84ac-795d4f0d1e5b?project_id=prd_jt

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 29, 2023
@takayuki5168 takayuki5168 force-pushed the feat/crosswalk-no-stop-decision-with-bracking-distance branch from 05159b5 to c377aa2 Compare August 29, 2023 16:44
@takayuki5168 takayuki5168 changed the title Feat/crosswalk no stop decision with bracking distance feat(crosswalk): no stop decision with bracking distance Aug 30, 2023
@takayuki5168 takayuki5168 changed the title feat(crosswalk): no stop decision with bracking distance feat(crosswalk): no stop decision with braking distance Aug 30, 2023
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 30, 2023 03:50
@takayuki5168 takayuki5168 force-pushed the feat/crosswalk-no-stop-decision-with-bracking-distance branch from c377aa2 to e587b50 Compare August 30, 2023 03:59
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ae1a5a7) 15.12% compared to head (e587b50) 15.12%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4802      +/-   ##
==========================================
- Coverage   15.12%   15.12%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      108231   108247      +16     
  Branches    33231    33232       +1     
==========================================
  Hits        16368    16368              
- Misses      74034    74044      +10     
- Partials    17829    17835       +6     
Flag Coverage Δ *Carryforward flag
differential 10.26% <0.00%> (?)
total 15.12% <ø> (+<0.01%) ⬆️ Carriedforward from ae1a5a7

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <0.00%> (ø)
...behavior_velocity_crosswalk_module/src/manager.cpp 10.81% <0.00%> (-0.62%) ⬇️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 58a5463 into autowarefoundation:main Aug 30, 2023
20 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/crosswalk-no-stop-decision-with-bracking-distance branch August 30, 2023 05:50
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 30, 2023
…dation#4802)

* feat(crosswalk): no stop decision with bracking distance

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 30, 2023
…dation#4802)

* feat(crosswalk): no stop decision with bracking distance

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 15, 2023
…dation#4802)

* feat(crosswalk): no stop decision with bracking distance

Signed-off-by: Takayuki Murooka <[email protected]>

* update config

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants