Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity): occlusion spot add partition lanelet #482

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 6, 2022

Related Issue(required)

#258

Description(required)

  • add partition lanelet with guard rail , fence ,wall tag

image

image

  • blocked by partition(left) not blocked by partition(right)
    image

The reason why it's necessary to refactor DebugData is DebugData was cleared at each step but in this PR partition lanelet is not going to be changed at every step so update DebugData Struct.

Review Procedure(required)

launch psim and place object inside and outside partition lanelet

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taikitanaka3 taikitanaka3 changed the title 258 feat occlusion spot add partition feat(behavior_velocity): occlusion spot add partition lanelet Mar 6, 2022
@@ -1,8 +1,9 @@
/**:
ros__parameters:
occlusion_spot:
method: "predicted_object" # [-] candidate is "occupancy_grid" or "predicted_object"
debug: false # [-] whether to publish debug markers. Note Default should be false for performance
method: "occupancy_grid" # [-] candidate is "occupancy_grid" or "predicted_object"
Copy link
Contributor Author

@taikitanaka3 taikitanaka3 Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note default
method: "predicted_object"
debug: false

change max_lateral_distance to 8.0 to see occlusion spot easily
detection_area:
max_lateral_distance: 8.0 # [m] buffer around the ego path used to build the detection area.

@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #482 (465808c) into main (84d3790) will decrease coverage by 4.79%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #482      +/-   ##
=========================================
- Coverage   10.94%   6.14%   -4.80%     
=========================================
  Files         705      70     -635     
  Lines       49721    4982   -44739     
  Branches     6656     694    -5962     
=========================================
- Hits         5440     306    -5134     
+ Misses      39919    4532   -35387     
+ Partials     4362     144    -4218     
Impacted Files Coverage Δ
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 40.00% <0.00%> (-26.67%) ⬇️
...vior_velocity_planner/include/utilization/util.hpp 12.00% <ø> (ø)
..._planner/src/scene_module/occlusion_spot/debug.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/occlusion_spot/manager.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 10.22% <0.00%> (+0.22%) ⬆️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...usion_spot/scene_occlusion_spot_in_public_road.cpp 0.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 32.43% <0.00%> (-1.62%) ⬇️
...ion/pose_initializer/src/pose_initializer_node.cpp
...ed_clock_rviz_plugin/src/simulated_clock_panel.cpp
... and 633 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d3790...465808c. Read the comment docs.

@taikitanaka3 taikitanaka3 marked this pull request as ready for review March 7, 2022 01:22
@taikitanaka3 taikitanaka3 added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 7, 2022
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Mar 7, 2022
* release v0.4.0

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit 7f877f288151212d5ee578f070fc7e11bd15ad9f.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Rename launch files to launch.xml (autowarefoundation#28)

* ROS2 Porting: scenario_selector (autowarefoundation#101)

* Add cmake and package.xml
 - Remove colcon ignore

* First pass:
 - Remove pubs and subs
 - Remove lane esoteric lanelet method calls

* Add parameter fetching and setting

* Add publishers, logging and transforms
 - Fix createCallback

* Remove duration field from lookuptransform

* Add topic_tools dependency
 - launching of rostopic in ROS1 hasn't been ported?

* Remove comments from cmake

* Remove boost dependency

* Remove test parameters

* Address PR comments:
 - Add const reference back
 - Use initializer list for parameter fetching
 - Fix fromBinMap reference
 - Launch publishing from executable tag in launch file

* Address PR comment:
 - Fix launch file launching of ros2 topic publisher

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* fixing trasient_local in ROS2 packages (autowarefoundation#160)

* [scenario_selector_node] fix timer frequency (autowarefoundation#182)

Signed-off-by: mitsudome-r <[email protected]>

* Add linters to scenario_selector (autowarefoundation#157)

* Added linters to scenario_selector

* Removed duplicate dependencies

* Add linters to CMake

* Only add cppcheck as linter

* Ros2 v0.8.0 scenario selector (autowarefoundation#294)

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <[email protected]>

* update first tf (autowarefoundation#1223)

* update first tf

Signed-off-by: Kosuke Murakami <[email protected]>

* update

Signed-off-by: Kosuke Murakami <[email protected]>

* Make planning modules components (autowarefoundation#1263)

Signed-off-by: wep21 <[email protected]>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* change trajectory callback implementation (autowarefoundation#1338) (autowarefoundation#1355)

* change trajectory callback implementation

* change name of callback function

* remove unnecessary function

* improve readability

Co-authored-by: satoshi-ota <[email protected]>

Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: satoshi-ota <[email protected]>

* Select LaneDriving scenario if vehicle is in lane and goal is in lane (autowarefoundation#1459) (autowarefoundation#1485)

Signed-off-by: Azumi Suzuki <[email protected]>
Signed-off-by: wep21 <[email protected]>

Co-authored-by: s-azumi <[email protected]>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* port scenario_selector (autowarefoundation#482)

* port scenario_selector

* remove COLCON_IGNORE

* use odom

* add nav_msgs dependency

Co-authored-by: Takayuki Murooka <[email protected]>

* [apply_predicted_obj_type] adapt to autoware auto msgs (autowarefoundation#564)

* fix obj shape

* fix obj shape

* fix goal pose

* rename topic name twist -> odometry (autowarefoundation#568)

Co-authored-by: Takayuki Murooka <[email protected]>

* update iv_msgs -> auto_msgs in planning readme (autowarefoundation#576)

* update iv_msgs -> auto_msgs in planning readme

* minor change

* some fix

* some fix

Co-authored-by: Takayuki Murooka <[email protected]>

* fix scenario selector (autowarefoundation#632)

* ci(pre-commit): autofix

* fix: package title

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Jilada Eccleston <[email protected]>
Co-authored-by: nik-tier4 <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: satoshi-ota <[email protected]>
Co-authored-by: s-azumi <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takeshi Miura <[email protected]>
yukkysaito
yukkysaito previously approved these changes Mar 10, 2022
@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Mar 10, 2022

@yukkysaito
I rebased to latest please approve again

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) March 10, 2022 15:19
@taikitanaka3 taikitanaka3 merged commit 1d36fae into autowarefoundation:main Mar 10, 2022
@taikitanaka3 taikitanaka3 deleted the 258-feat-occlusion-spot-add-partition branch March 11, 2022 02:02
taikitanaka3 referenced this pull request in tier4/autoware.universe Mar 16, 2022
* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 9, 2022
* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
…refoundation#482)

* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
)

* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
)

* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
)

* feat(behavior_velocity): add partition lanelet

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): add get partition lanelet to utils

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): remove unused function

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): unite variables

Signed-off-by: taikitanaka <[email protected]>

* feat(behavior_velocity): apply concept of partition

Signed-off-by: taikitanaka <[email protected]>

* chore(behavior_velocity): change partition marker color

Signed-off-by: tanaka3 <[email protected]>

* doc(behavior_velocity): update doc

Signed-off-by: tanaka3 <[email protected]>

* chore(behavior_velocity): to default setting

Signed-off-by: tanaka3 <[email protected]>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
* feat(planning_launch): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <[email protected]>

* feat(planning_launch): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <[email protected]>

Signed-off-by: satoshi-ota <[email protected]>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request May 16, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request May 16, 2023
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
* ci(sync-files): fix relative links

Signed-off-by: Kenji Miyake <[email protected]>

* use string mode

Signed-off-by: Kenji Miyake <[email protected]>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
[universe]
33dbaa4 feat(tier4_perception_launch): make switchable detection by tracker in x2 project (autowarefoundation#964)
940fb2b Merge pull request autowarefoundation#965 from tier4/beta/v0.11.0+PR5356
5aa9db1 feat(map_based_prediction): remove crossing fence path (autowarefoundation#5356)
[common]
c3a1a19 fix(visualization): display traffic reg elem id (autowarefoundation#210)
36b3825 feat(lanelet2_extention): add getAllFences (autowarefoundation#209)
44dc388 docs(lanelet2_extension): add brief description for crosswalk traffic light (autowarefoundation#208)
c360614 feat(lanelet2_extensions): add query curbstones from vector map (autowarefoundation#206)
[launcher]
a2f88f00 feat(autoware_launch): longer prediction 15.0 -> 20.0 (autowarefoundation#482)
87974c0f fix: fix stop_duration_sec param for merge_from_private (autowarefoundation#516)
f5a1dfad fix(autoware_launch): fix parameter for light weight grand segmentation (autowarefoundation#506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants