Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_cmd_gate): use real velocity for the lateral filter #4918

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 7, 2023

Description

Use the real velocity for the lateral command filter.
Otherwise, if the velocity command oscillates, the filtered steering oscillates.
The drawback is that it won't guarantee the constraints are met in the series of the output command itself. (We need to see the actual velocity data to check it.) But this is much safer than the previous implementation.

Related links

TIERIV Internal ticket

Tests performed

Run in a real vehicle testing and it worked well.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

Improve the filtering. No effect in the default parameter.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 7, 2023
@TakaHoribe TakaHoribe added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 7, 2023
@TakaHoribe
Copy link
Contributor Author

Need to fix test

Signed-off-by: Takamasa Horibe <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 36.17% and no project coverage change.

Comparison is base (2e6bc3f) 15.92% compared to head (1f72f71) 15.93%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4918   +/-   ##
=======================================
  Coverage   15.92%   15.93%           
=======================================
  Files        1579     1579           
  Lines      108886   108895    +9     
  Branches    33584    33586    +2     
=======================================
+ Hits        17344    17352    +8     
  Misses      72944    72944           
- Partials    18598    18599    +1     
Flag Coverage Δ *Carryforward flag
differential 41.69% <36.17%> (?)
total 15.92% <ø> (-0.01%) ⬇️ Carriedforward from 2e6bc3f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 25.00% <ø> (ø)
...icle_cmd_gate/test/src/test_vehicle_cmd_filter.cpp 42.48% <23.68%> (+1.94%) ⬆️
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp 72.02% <87.50%> (+0.39%) ⬆️
.../test/src/test_filter_in_vehicle_cmd_gate_node.cpp 60.81% <100.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkimura4 tkimura4 merged commit 8c514cf into autowarefoundation:main Sep 11, 2023
20 of 23 checks passed
@tkimura4 tkimura4 deleted the use-real-vel-gate-filter branch September 11, 2023 09:53
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 16, 2023
…warefoundation#4918)

* fix(vehicle_cmd_gate): use real velocity for the lateral filter

Signed-off-by: Takamasa Horibe <[email protected]>

* fix test

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants