fix(rviz config): remove initial_pose_button_panel #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamato-ando <Yamato ANDO>
github-actions
bot
added
component:perception
YamatoAndo
requested review from
taikitanaka3,
1222-takeshi,
tkimura4,
kosuke55,
takayuki5168,
TakaHoribe,
knzo25 and
yukke42
as code owners
YamatoAndo
added
the
tag:run-build-and-test-differential
kosuke55
approved these changes
Sep 12, 2023
takayuki5168
approved these changes
Sep 12, 2023
TakaHoribe
approved these changes
Sep 12, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4959 +/- ##
==========================================
- Coverage 15.80% 15.67% -0.14%
==========================================
Files 1580 1607 +27
Lines 109179 110114 +935
Branches 33646 33646
==========================================
Hits 17258 17258
- Misses 73313 74248 +935
Partials 18608 18608
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@yukke42 @knzo25 Please review this PR about @tkimura4 @taikitanaka3 @1222-takeshi Please review this PR about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4848
rviz reports the following error:
This plugin was removed #4519.
So I will also remove tier4_localization_rviz_plugin/InitialPoseButtonPanel from the rviz cofings.
Tests performed
I have confirmed that no errors occur when launching RViz with each rviz config file.
like this.
ros2 run rviz2 rviz2 -d src/universe/autoware.universe/planning/obstacle_avoidance_planner/rviz/obstacle_avoidance_planner.rvizEffects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.