Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(control_validator): use throttle for the error log #4960

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 12, 2023

Description

Use log_throttle for the error message, otherwise the terminal is filled by the same log.

Tests performed

run psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 12, 2023
@TakaHoribe TakaHoribe added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 12, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) September 12, 2023 07:56
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (82006db) 15.80% compared to head (bfb39ab) 15.80%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4960   +/-   ##
=======================================
  Coverage   15.80%   15.80%           
=======================================
  Files        1580     1580           
  Lines      109179   109179           
  Branches    33646    33646           
=======================================
  Hits        17258    17258           
  Misses      73313    73313           
  Partials    18608    18608           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.80% <ø> (+<0.01%) ⬆️ Carriedforward from 82006db

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/control_validator/src/control_validator.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.43% <ø> (ø)
...optimizer/src/static_centerline_optimizer_node.cpp 15.76% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe merged commit 3e28ab5 into autowarefoundation:main Sep 12, 2023
34 of 36 checks passed
@TakaHoribe TakaHoribe deleted the throttle-control-validator branch September 12, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants