-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): keep max back distace whithin lanes #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <[email protected]>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
September 12, 2023 07:28
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 12, 2023
kosuke55
added
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
and removed
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
labels
Sep 12, 2023
planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp
Show resolved
Hide resolved
…start_planner_module.cpp Co-authored-by: Kyoichi Sugahara <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 12, 2023
kosuke55
commented
Sep 12, 2023
planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp
Outdated
Show resolved
Hide resolved
…start_planner_module.cpp
kyoichi-sugahara
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(sorry for confusing 🙇 )
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…dation#4962) * fix(start_planner): keep max back distace whithin lanes Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55
added a commit
to kosuke55/autoware.universe
that referenced
this pull request
Sep 12, 2023
…dation#4962) * fix(start_planner): keep max back distace whithin lanes Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…dation#4962) * fix(start_planner): keep max back distace whithin lanes Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…dation#4962) * fix(start_planner): keep max back distace whithin lanes Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 16, 2023
…dation#4962) * fix(start_planner): keep max back distace whithin lanes Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
keep max back distace whithin lanes
Related links
Tests performed
2023/09/12 https://evaluation.tier4.jp/evaluation/reports/ded9ec4d-2479-5b6b-ab63-c7334cdc97e3/?project_id=prd_jt
1650/1650
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.