Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(start_planner): keep max back distace whithin lanes #4962

Merged
merged 4 commits into from
Sep 12, 2023
Merged

fix(start_planner): keep max back distace whithin lanes #4962

merged 4 commits into from
Sep 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 12, 2023 •
edited
Loading

Description

keep max back distace whithin lanes

Related links

Tests performed

2023/09/12 https://evaluation.tier4.jp/evaluation/reports/ded9ec4d-2479-5b6b-ab63-c7334cdc97e3/?project_id=prd_jt

1650/1650

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 12, 2023
@kosuke55 kosuke55 added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Sep 12, 2023
@kosuke55 @kyoichi-sugahara
Update planning/behavior_path_planner/src/scene_module/start_planner/…
da4eae2 
…start_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 12, 2023
kyoichi-sugahara
kyoichi-sugahara approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(sorry for confusing 🙇 )

@kosuke55 kosuke55 enabled auto-merge (squash) September 12, 2023 10:55
@kosuke55 kosuke55 merged commit cd83dc6 into main Sep 12, 2023
19 of 20 checks passed
@kosuke55 kosuke55 deleted the fix/calc_max_back_distance_to_keep_in_lane branch September 12, 2023 11:08
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
@kosuke55 @kyoichi-sugahara @pre-commit-ci
fix(start_planner): keep max back distace whithin lanes (autowarefoun…
190009e 
…dation#4962)

* fix(start_planner): keep max back distace whithin lanes

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request Sep 12, 2023
@kosuke55 @kyoichi-sugahara @pre-commit-ci
fix(start_planner): keep max back distace whithin lanes (autowarefoun…
192d1bc 
…dation#4962)

* fix(start_planner): keep max back distace whithin lanes

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
@kosuke55 @kyoichi-sugahara @pre-commit-ci
fix(start_planner): keep max back distace whithin lanes (autowarefoun…
144e87d 
…dation#4962)

* fix(start_planner): keep max back distace whithin lanes

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 12, 2023
Merged
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
@kosuke55 @kyoichi-sugahara @pre-commit-ci
fix(start_planner): keep max back distace whithin lanes (autowarefoun…
01ea30d 
…dation#4962)

* fix(start_planner): keep max back distace whithin lanes

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
@kosuke55 @kyoichi-sugahara @pre-commit-ci
fix(start_planner): keep max back distace whithin lanes (autowarefoun…
bb89430 
…dation#4962)

* fix(start_planner): keep max back distace whithin lanes

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/start_planner/start_planner_module.cpp

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@rej55 rej55 Awaiting requested review from rej55

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@shmpwk shmpwk Awaiting requested review from shmpwk

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

Assignees

@kyoichi-sugahara kyoichi-sugahara

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosuke55 @kyoichi-sugahara