-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radar_tracks_msg_converter): fix twist coordinate conversion #4993
fix(radar_tracks_msg_converter): fix twist coordinate conversion #4993
Conversation
Signed-off-by: scepter914 <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4993 +/- ##
==========================================
+ Coverage 15.74% 15.76% +0.01%
==========================================
Files 1587 1587
Lines 109831 109555 -276
Branches 33719 33578 -141
==========================================
- Hits 17292 17268 -24
+ Misses 73908 73697 -211
+ Partials 18631 18590 -41
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
…owarefoundation#4993) Signed-off-by: scepter914 <[email protected]>
Description
Fix twist coordinate conversion in radar_track_msg_converter.
Twist coordinate conversion fail for other than the front radar, so this PR fixes it.
Left direction is front.
radar_tracks_msg_converter
of rear center radar estimate moving in the opposite direction to the car following ego vehicle.Left direction is front.
radar_tracks_msg_converter
of rear center radar can estimate twist correctly.Related links
Tests performed
Test by rosbag.
Notes for reviewers
Interface changes
None
Effects on system behavior
This PR change the behavior for the sensor system that has multi radars.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.