Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_tracks_msg_converter): fix twist coordinate conversion #4993

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 14, 2023

Description

Fix twist coordinate conversion in radar_track_msg_converter.
Twist coordinate conversion fail for other than the front radar, so this PR fixes it.

  • Before

Left direction is front.
radar_tracks_msg_converter of rear center radar estimate moving in the opposite direction to the car following ego vehicle.

Screenshot from 2023-09-13 22-00-32

  • After

Left direction is front.
radar_tracks_msg_converter of rear center radar can estimate twist correctly.

Screenshot from 2023-09-13 22-32-54

Related links

Tests performed

Test by rosbag.

Notes for reviewers

Interface changes

None

Effects on system behavior

This PR change the behavior for the sensor system that has multi radars.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 14, 2023
@scepter914 scepter914 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (ea9d4b0) 15.74% compared to head (903b598) 15.76%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4993      +/-   ##
==========================================
+ Coverage   15.74%   15.76%   +0.01%     
==========================================
  Files        1587     1587              
  Lines      109831   109555     -276     
  Branches    33719    33578     -141     
==========================================
- Hits        17292    17268      -24     
+ Misses      73908    73697     -211     
+ Partials    18631    18590      -41     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.76% <ø> (+0.01%) ⬆️ Carriedforward from c2c5fb5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
common/geography_utils/src/lanelet2_projector.cpp 77.77% <ø> (+36.60%) ⬆️
...ted_object/src/radar_fusion_to_detected_object.cpp 0.00% <ø> (ø)
...onverter_node/radar_tracks_msgs_converter_node.cpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <ø> (ø)
..._safety_checker/path_safety_checker_parameters.hpp 50.00% <ø> (+16.66%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.28% <ø> (+0.59%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 8.48% <ø> (-0.02%) ⬇️
..._planner/src/scene_module/goal_planner/manager.cpp 5.48% <ø> (-0.08%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.05% <ø> (+<0.01%) ⬆️
...planner/src/scene_module/start_planner/manager.cpp 4.60% <ø> (-0.26%) ⬇️
... and 5 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh
Copy link
Contributor

miursh commented Sep 19, 2023

Tested with a rosbag
image

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 51fa0f5 into autowarefoundation:main Sep 19, 2023
21 of 24 checks passed
@scepter914 scepter914 deleted the fix/radar_tracks_msg_converter_twist branch September 19, 2023 05:16
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 29, 2023
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 29, 2023
miursh pushed a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants