Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object_merger): fixed sync_queue_size parameter #5058

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(object_merger): fixed sync_queue_size parameter #5058

merged 1 commit into from
Sep 21, 2023

Conversation

FranzAlbers
Copy link
Contributor

Description

#4994 introduced a minor bug, because a new parameter was not passed appropriately:

[object_association_merger_node-45] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidParameterTypeException'
[object_association_merger_node-45]   what():  parameter 'sync_queue_size' has invalid type: Wrong parameter type, parameter {sync_queue_size} is of type {integer}, setting it to {string} is not allowed.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 20, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 21, 2023
@yukkysaito yukkysaito enabled auto-merge (squash) September 21, 2023 00:46
@yukkysaito yukkysaito merged commit d2c2de2 into autowarefoundation:main Sep 21, 2023
27 of 28 checks passed
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (27220a8) 15.81% compared to head (ae7e75d) 15.81%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5058   +/-   ##
=======================================
  Coverage   15.81%   15.81%           
=======================================
  Files        1581     1581           
  Lines      109896   109895    -1     
  Branches    34411    34411           
=======================================
  Hits        17375    17375           
+ Misses      73394    73393    -1     
  Partials    19127    19127           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.81% <ø> (+<0.01%) ⬆️ Carriedforward from 27220a8

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <ø> (ø)
...ol/operation_mode_transition_manager/src/state.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants