-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change, pull_over): fix predicted path size is small case #517
Merged
tkimura4
merged 2 commits into
autowarefoundation:main
from
1222-takeshi:fix/fix-lane-change-and-pull-over-utils
Mar 15, 2022
Merged
fix(lane_change, pull_over): fix predicted path size is small case #517
tkimura4
merged 2 commits into
autowarefoundation:main
from
1222-takeshi:fix/fix-lane-change-and-pull-over-utils
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without resizing, behavior_planner throws the following error on this line.
This PR fixed this. |
tkimura4
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mkuri
pushed a commit
to mkuri/autoware.universe
that referenced
this pull request
Mar 15, 2022
* release v0.4.0 * fixed bug (autowarefoundation#717) * Add nodelets of tlr nodes (autowarefoundation#715) * Add classifier nodelet Signed-off-by: Daisuke Nishimatsu <[email protected]> * Replace boost::shared_ptr into std::shared_ptr Signed-off-by: Daisuke Nishimatsu <[email protected]> * Add lock guard Signed-off-by: Daisuke Nishimatsu <[email protected]> * Add detetcor nodelet Signed-off-by: Daisuke Nishimatsu <[email protected]> * Integrate main into node Signed-off-by: Daisuke Nishimatsu <[email protected]> * Add SubscriberStatusCallback Signed-off-by: Daisuke Nishimatsu <[email protected]> * add image_transport_decompresser nodelet Signed-off-by: Yukihiro Saito <[email protected]> * Add visualizer nodelet Signed-off-by: Daisuke Nishimatsu <[email protected]> * fixed bug Signed-off-by: Yukihiro Saito <[email protected]> * Fix plugin name Signed-off-by: Daisuke Nishimatsu <[email protected]> * Launch nodelet Signed-off-by: Daisuke Nishimatsu <[email protected]> * Fix classifier constructor Signed-off-by: Daisuke Nishimatsu <[email protected]> * add decompresser node Signed-off-by: Yukihiro Saito <[email protected]> * fix typo Signed-off-by: Yukihiro Saito <[email protected]> * fixed bug Signed-off-by: Yukihiro Saito <[email protected]> * fixed bug Signed-off-by: Yukihiro Saito <[email protected]> * cosmetic change Signed-off-by: Yukihiro Saito <[email protected]> * add param Signed-off-by: Yukihiro Saito <[email protected]> * fix bug Signed-off-by: Yukihiro Saito <[email protected]> * Fix build warning Signed-off-by: Daisuke Nishimatsu <[email protected]> * change rgb Signed-off-by: Yukihiro Saito <[email protected]> * change rgb Signed-off-by: Yukihiro Saito <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <[email protected]> * Revert "remove ROS1 packages temporarily" This reverts commit e884716313c52a9392fe58f3e6a1c95e7515725e. Signed-off-by: mitsudome-r <[email protected]> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <[email protected]> * Rename launch files to launch.xml (autowarefoundation#28) * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Port traffic light visualization (autowarefoundation#121) * Port Signed-off-by: Servando German Serrano <[email protected]> * Fix package.xml Signed-off-by: Servando German Serrano <[email protected]> * Removed unused mutex Signed-off-by: Servando German Serrano <[email protected]> * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * support traffic_light_state in traffi_light_visualization (autowarefoundation#1115) (autowarefoundation#339) * support traffic_light_state in traffi_light_visualization * support unsynced detection and classification result * apply clang-format Co-authored-by: Taichi Higashide <[email protected]> * add use_sim-time option (autowarefoundation#454) * Sync public repo (autowarefoundation#1228) * [simple_planning_simulator] add readme (autowarefoundation#424) * add readme of simple_planning_simulator Signed-off-by: Takamasa Horibe <[email protected]> * Update simulator/simple_planning_simulator/README.md * set transit_margin_time to intersect. planner (autowarefoundation#460) * Fix pose2twist (autowarefoundation#462) Signed-off-by: Takagi, Isamu <[email protected]> * Ros2 vehicle info param server (autowarefoundation#447) * add vehicle_info_param_server * update vehicle info * apply format * fix bug * skip unnecessary search * delete vehicle param file * fix bug * Ros2 fix topic name part2 (autowarefoundation#425) * Fix topic name of traffic_light_classifier Signed-off-by: Takagi, Isamu <[email protected]> * Fix topic name of traffic_light_visualization Signed-off-by: Takagi, Isamu <[email protected]> * Fix topic name of traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <[email protected]> * Fix topic name of traffic_light_map_based_detector Signed-off-by: Takagi, Isamu <[email protected]> * Fix lint traffic_light_recognition Signed-off-by: Takagi, Isamu <[email protected]> * Fix lint traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <[email protected]> * Fix lint traffic_light_classifier Signed-off-by: Takagi, Isamu <[email protected]> * Fix lint traffic_light_classifier Signed-off-by: Takagi, Isamu <[email protected]> * Fix lint traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <[email protected]> * Fix issues in hdd_reader (autowarefoundation#466) * Fix some issues detected by Coverity Scan and Clang-Tidy * Update launch command * Add more `close(new_sock)` * Simplify the definitions of struct * fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463) * Rviz overlay render fix (autowarefoundation#461) * Moved painiting in SteeringAngle plugin to update() Signed-off-by: Adam Dabrowski <[email protected]> * super class now back to MFD Signed-off-by: Adam Dabrowski <[email protected]> * uncrustified Signed-off-by: Adam Dabrowski <[email protected]> * acquire data in mutex Signed-off-by: Adam Dabrowski <[email protected]> * back to RTD as superclass Signed-off-by: Adam Dabrowski <[email protected]> * Rviz overlay render in update (autowarefoundation#465) * Moved painiting in SteeringAngle plugin to update() Signed-off-by: Adam Dabrowski <[email protected]> * super class now back to MFD Signed-off-by: Adam Dabrowski <[email protected]> * uncrustified Signed-off-by: Adam Dabrowski <[email protected]> * acquire data in mutex Signed-off-by: Adam Dabrowski <[email protected]> * removed unnecessary includes and some dead code Signed-off-by: Adam Dabrowski <[email protected]> * Adepted remaining vehicle plugin classes to render-in-update concept. Returned to MFD superclass Signed-off-by: Adam Dabrowski <[email protected]> * restored RTD superclass Signed-off-by: Adam Dabrowski <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: tkimura4 <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Makoto Tokunaga <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <[email protected]> * Use sensor data qos for traffic light recognition (autowarefoundation#1440) Signed-off-by: wep21 <[email protected]> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <[email protected]> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: pre-commit <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * Porting traffic light viz (autowarefoundation#1284) * Feature/traffic light viz (autowarefoundation#1001) * add tl map viz * bug fix * update map visualizer * add launch * add install in cmake * remove unused file * fix build error * Fix lint Signed-off-by: wep21 <[email protected]> * Fix typo Signed-off-by: wep21 <[email protected]> * Fix topic name and qos Signed-off-by: wep21 <[email protected]> * Replace deprecated duration api Signed-off-by: wep21 <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> Co-authored-by: wep21 <[email protected]> * suppress warnings for traffic light classifier (autowarefoundation#1762) * add Werror * fix type * fix unused * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <[email protected]> * Fix mistake Signed-off-by: Kenji Miyake <[email protected]> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <[email protected]> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <[email protected]> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <[email protected]> * Apply Black Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <[email protected]> * [traffic_light_visualization] support autoware auto msgs (autowarefoundation#517) * doc traffic light visualizer (autowarefoundation#628) * add readme * run pre-commit * add purpose * fix typo * run pre-commit * remove reference * update descriptions * Update traffic light topic name (autowarefoundation#729) * Update traffic light topic name Signed-off-by: wep21 <[email protected]> * Update traffic light topic name in perception Signed-off-by: wep21 <[email protected]> Co-authored-by: mitsudome-r <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Nikolai Morin <[email protected]> Co-authored-by: Servando <[email protected]> Co-authored-by: Shinnosuke Hirakawa <[email protected]> Co-authored-by: Taichi Higashide <[email protected]> Co-authored-by: tkimura4 <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Makoto Tokunaga <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: pre-commit <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: wep21 <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Satoshi OTA <[email protected]> Co-authored-by: Takeshi Miura <[email protected]>
tkimura4
referenced
this pull request
in tier4/autoware.universe
Oct 24, 2022
Signed-off-by: yutaka <[email protected]> Signed-off-by: yutaka <[email protected]>
kosuke55
pushed a commit
to kosuke55/autoware.universe
that referenced
this pull request
May 29, 2023
fix(intersection): decide go/stop by checking pass judge (autowarefoundation#3711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(required)
Description(required)
Fixed segmentation fault when predicted path size was small.
sample code
Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks