refactor(behavior_velocity): move inline functions to cpp and remove unused

[taikitanaka3]

Signed-off-by: tanaka3 [email protected]

Related Issue(required)

#258

Description(required)

refactor inline functions

Review Procedure(required)

see build pass (no behavior change)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Read commit-guidelines
• Assign PR to reviewer

If you are adding new package following items are required:

• Documentation with description of the package is available
• A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR / build-and-test-pr: Required to pass before the merge.
• Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
• Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

[yukkysaito]

I want to change the precision of double to float where it is not needed.

[codecov]

Codecov Report

Merging #462 (1e31291) into tier4/proposal (9b605cb) will decrease coverage by 4.71%.
The diff coverage is 48.14%.

@@                Coverage Diff                @@
##           tier4/proposal    #462      +/-   ##
=================================================
- Coverage           10.99%   6.27%   -4.72%     
=================================================
  Files                 705      70     -635     
  Lines               49458    4873   -44585     
  Branches             6646     667    -5979     
=================================================
- Hits                 5436     306    -5130     
+ Misses              39663    4423   -35240     
+ Partials             4359     144    -4215     

Impacted Files	Coverage Δ
...ene_module/occlusion_spot/occlusion_spot_utils.hpp	66.66% <ø> (+58.33%)	⬆️
...ene_module/occlusion_spot/occlusion_spot_utils.cpp	10.00% <0.00%> (-1.12%)	⬇️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp	0.00% <0.00%> (ø)
...usion_spot/scene_occlusion_spot_in_public_road.cpp	0.00% <0.00%> (ø)
..._module/occlusion_spot/risk_predictive_braking.cpp	56.75% <86.66%> (+20.39%)	⬆️
...ject_tracker/data_association/data_association.hpp
.../include/planning_evaluator/metrics_calculator.hpp
...jectory_follower/longitudinal_controller_utils.hpp
...monitor/src/ad_service_state_monitor_node/main.cpp
...ator/include/planning_evaluator/metrics/metric.hpp
... and 629 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b605cb...1e31291. Read the comment docs.

[taikitanaka3]

@yukkysaito
I agree to change at many iteration codes like grid map or plygon but this refactoring doesn't include many iteration code. So what you mentioned will be on another PR.
Is it ok？