Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization_error_monitor): update parameter #5201

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 2, 2023

Description

Update parameter.
Current Autoware's EKF may ignore low velocity depending on the zero band of its sensor, making the localization error covariance larger. With this update, we can suppress such warnings with the default value, improving the usability for OSS users. Note that it is always recommended to tune the parameters for each vehicle.

autowarefoundation/autoware_launch#614

Tests performed

Tested on pilot-auto.x2

Effects on system behavior

Threshold of localization_accuracy gets larger.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 2, 2023
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (93b6118) 14.77% compared to head (53c527b) 14.79%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5201      +/-   ##
==========================================
+ Coverage   14.77%   14.79%   +0.01%     
==========================================
  Files        1636     1636              
  Lines      113635   113541      -94     
  Branches    34932    34877      -55     
==========================================
+ Hits        16793    16795       +2     
+ Misses      78001    77912      -89     
+ Partials    18841    18834       -7     
Flag Coverage Δ *Carryforward flag
differential 21.46% <ø> (?)
total 14.79% <ø> (+0.01%) ⬆️ Carriedforward from e337576

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 12.33% <ø> (+<0.01%) ⬆️
...em_monitor/src/process_monitor/process_monitor.cpp 0.00% <ø> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit a6af44e into autowarefoundation:main Oct 2, 2023
25 checks passed
@kminoda kminoda deleted the feat/localization_error_monitor/update_parameter branch October 2, 2023 22:14
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Oct 2, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 4, 2023
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants