-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_perception_launch): fix faraway detection to reduce calculation cost #5233
fix(tier4_perception_launch): fix faraway detection to reduce calculation cost #5233
Conversation
….launch Signed-off-by: scepter914 <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5233 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1648 1648
Lines 113963 113945 -18
Branches 35110 35084 -26
=======================================
- Hits 16846 16844 -2
- Misses 78177 78180 +3
+ Partials 18940 18921 -19
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: scepter914 <[email protected]>
…914/autoware.universe into fix/light_weight_radar_detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion cost (autowarefoundation#5233) * fix(tier4_perception_launch): fix node order in radar_based_detection.launch Signed-off-by: scepter914 <[email protected]> * fix comment out unused node Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]>
…tion cost (#919) fix(tier4_perception_launch): fix faraway detection to reduce calculation cost (autowarefoundation#5233) * fix(tier4_perception_launch): fix node order in radar_based_detection.launch * fix comment out unused node --------- Signed-off-by: scepter914 <[email protected]>
…tion cost (autowarefoundation#5233) * fix(tier4_perception_launch): fix node order in radar_based_detection.launch Signed-off-by: scepter914 <[email protected]> * fix comment out unused node Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]>
Description
This PR fixes node order in radar_based_detection.launch to reduce calculation cost.
radar_object_tracker
Tests performed
Tests by rosbag
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.