fix(tier4_perception_launch): fix faraway detection to reduce calculation cost #5233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….launch Signed-off-by: scepter914 <[email protected]>
scepter914
requested review from
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:launch
scepter914
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5233 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1648 1648
Lines 113963 113945 -18
Branches 35110 35084 -26
=======================================
- Hits 16846 16844 -2
- Misses 78177 78180 +3
+ Partials 18940 18921 -19
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: scepter914 <[email protected]>
…914/autoware.universe into fix/light_weight_radar_detection
scepter914
changed the title
scepter914
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 6, 2023
…tion cost (autowarefoundation#5233) * fix(tier4_perception_launch): fix node order in radar_based_detection.launch Signed-off-by: scepter914 <[email protected]> * fix comment out unused node Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]>
7 tasks
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 7, 2023
…tion cost (#919) fix(tier4_perception_launch): fix faraway detection to reduce calculation cost (autowarefoundation#5233) * fix(tier4_perception_launch): fix node order in radar_based_detection.launch * fix comment out unused node --------- Signed-off-by: scepter914 <[email protected]>
This was referenced Oct 11, 2023
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Oct 16, 2023
…tion cost (autowarefoundation#5233) * fix(tier4_perception_launch): fix node order in radar_based_detection.launch Signed-off-by: scepter914 <[email protected]> * fix comment out unused node Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes node order in radar_based_detection.launch to reduce calculation cost.
radar_object_trackerTests performed
Tests by rosbag
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.