-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner_common): sync activation when safety status is set #5697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus is set Signed-off-by: Fumiya Watanabe <[email protected]>
rej55
requested review from
taikitanaka3,
isamu-takagi,
shmpwk and
tkimura4
as code owners
November 28, 2023 06:38
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 28, 2023
rej55
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 28, 2023
..._velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp
Outdated
Show resolved
Hide resolved
kyoichi-sugahara
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ocity_planner_common/scene_module_interface.hpp Co-authored-by: Kyoichi Sugahara <[email protected]>
taikitanaka3
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tkimura4
approved these changes
Nov 28, 2023
shmpwk
approved these changes
Nov 28, 2023
tkimura4
reviewed
Nov 28, 2023
..._velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp
Outdated
Show resolved
Hide resolved
…ocity_planner_common/scene_module_interface.hpp Co-authored-by: Tomoya Kimura <[email protected]>
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 29, 2023
…atus is set (autowarefoundation#5697) * fix(behavior_velocity_planner_common): sync activation when safety status is set Signed-off-by: Fumiya Watanabe <[email protected]> * Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Tomoya Kimura <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]>
7 tasks
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…atus is set (autowarefoundation#5697) * fix(behavior_velocity_planner_common): sync activation when safety status is set Signed-off-by: Fumiya Watanabe <[email protected]> * Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Kyoichi Sugahara <[email protected]> * Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Tomoya Kimura <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]> Co-authored-by: Kyoichi Sugahara <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, activation status is not updated in the cycle that safety status changed.
In this PR, it enables to sync activation status with current safety status.
Related links
Tests performed
TIER IV INTERNAL TEST
Planning simulator.
Before:
After:
Notes for reviewers
Interface changes
Not applicable.
Effects on system behavior
Activation status will be updated in the cycle that safety status updated.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.