Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner_common): sync activation when safety status is set #5697

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Nov 28, 2023

Description

Before this change, activation status is not updated in the cycle that safety status changed.
In this PR, it enables to sync activation status with current safety status.

Related links

Tests performed

TIER IV INTERNAL TEST

Planning simulator.

Before:

image_720

After:

Screenshot from 2023-11-28 15-30-22

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Activation status will be updated in the cycle that safety status updated.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 28, 2023
@rej55 rej55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2301 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (f75b721) 12.71%.
Report is 88 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 13.19% 597 Missing and 87 partials ⚠️
...anner/src/utils/avoidance/shift_line_generator.cpp 13.28% 431 Missing and 65 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.56% 175 Missing and 2 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.35% 164 Missing and 9 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.56% 110 Missing and 17 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 84 Missing ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.81% 54 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.62% 53 Missing ⚠️
...behavior_velocity_out_of_lane_module/src/debug.cpp 11.66% 44 Missing and 9 partials ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5697      +/-   ##
==========================================
- Coverage   15.32%   12.71%   -2.61%     
==========================================
  Files        1721      231    -1490     
  Lines      118559    24295   -94264     
  Branches    37995    13437   -24558     
==========================================
- Hits        18169     3090   -15079     
+ Misses      79657    16960   -62697     
+ Partials    20733     4245   -16488     
Flag Coverage Δ
differential 12.71% <12.04%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ocity_planner_common/scene_module_interface.hpp

Co-authored-by: Kyoichi Sugahara <[email protected]>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ocity_planner_common/scene_module_interface.hpp

Co-authored-by: Tomoya Kimura <[email protected]>
@tkimura4 tkimura4 merged commit e6709ee into autowarefoundation:main Nov 29, 2023
20 of 24 checks passed
@rej55 rej55 deleted the fix/set_activation branch November 29, 2023 05:19
rej55 added a commit to tier4/autoware.universe that referenced this pull request Nov 29, 2023
…atus is set (autowarefoundation#5697)

* fix(behavior_velocity_planner_common): sync activation when safety status is set

Signed-off-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp

Co-authored-by: Tomoya Kimura <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…atus is set (autowarefoundation#5697)

* fix(behavior_velocity_planner_common): sync activation when safety status is set

Signed-off-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp

Co-authored-by: Kyoichi Sugahara <[email protected]>

* Update planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/scene_module_interface.hpp

Co-authored-by: Tomoya Kimura <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Kyoichi Sugahara <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants