Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ali/simple planning simulator with disturbance generator #573

Conversation

boyali
Copy link
Contributor

@boyali boyali commented Mar 23, 2022

Note: Confirm our contribution guidelines before submitting a pull request.

Click the Preview tab and select a PR template:

  • Small change
  • We implemented disturbance generator classes for the simple_planning_simulator.

@boyali boyali requested a review from TakaHoribe March 23, 2022 06:10
angry-crab pushed a commit to angry-crab/autoware.universe that referenced this pull request Mar 24, 2022
* rename gnss package (autowarefoundation#714)

Signed-off-by: Yamato Ando <[email protected]>

* Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (autowarefoundation#720)

* remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt

* remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified

* set compile options for debug in ndt_omp

* Fix indent

* add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp

Co-authored-by: Kenji Miyake <[email protected]>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit bc523d679e6737ec37be4fdcbdedca141411bd9d.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* ROS2 Porting: geo_pos_conv (autowarefoundation#8)

* Convert to ROS2 package
 - Update changelog -> 2.0.0
 - Update package xml to use the ROS2 xml schema
 - Update CMakelist with ament cmake commands
 - Add ROS2 compile options

* Convert CMakelist for foxy

* Clean up
 - Remove comments

* Remove colcon ignore

* Rename launch files to launch.xml (autowarefoundation#28)

* ROS2 Porting: gnss_poser (autowarefoundation#18)

* Fix CMakelist
 - Add ublox_msgs package dependency
 - Rename header files to use the .hpp extention
 - Remove colcon ignore
 - Fix Cmake ref to ublox in dependency

* Fix compilation issues with convert.hpp
 - Add sensor_msgs::NavSatFix header which was missing before (?)
 - Remove logging for now
 - Contains warnings - geographic lib error polymorphous error
 - Fix geographic lib -Wcatch-value warnings
 - Add ifndef guard in gnss_stat.hpp

* First pass - successful compilation
 - Fix CMakelist geographic library
 - Remove references to main ROS functions
 - Convert msg references
 - Add ifndef guards
 - Convert tf2 methods
 - Add functionality back
 - Fix type errors

* Add publishers and subscribers
 - Add parameters

* Convert launch files to ROS2 format

* Add logging

* Convert to component

* Fix define guards to follow ROS2/Google style

* Add -Werror compile flag

* Clean up

* Fix CMakelist to allow for the node to be found via ros2 launch
 - Revert filenames so it is easier to review

* Address PR Comments:
 - Fix CMakelist and package.xml
 - Remove redundant depend/exec_depend calls
 - Remove redundant find_package calls
 - Explicitly add headers to the library

* Address PR comments:
 - Revert removal of GNSSPoser namespace
 - Use std::make_shared in place of new
 - Reorder includes to conform with standard

* Address PR Comments:
 - Rename variable to conform with the google style guide
 - Use the node clock in logging method calls

* Address PR Comment:
 - Convert transform broadcaster to shared pointer

* Address PR comment:
 - Remove -Werror compile flag post discussion

* fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75)

Signed-off-by: Takamasa Horibe <[email protected]>

* [gnss_poser] switch broadcaster to full member... (autowarefoundation#136)

instead of `shared_ptr` to avoid undefined behavior when executing the node because it used `shared_from_this()` in the constructor

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: geo_pos_conv (autowarefoundation#165)

* Add linters and fix linter issues
 - convert Cmake to use ament_cmake_auto

* Address PR comments:
 - Remove unneeded cast
 - Throw error instead of setting default values to zero

* ROS2 Linting: gnss_poser (autowarefoundation#166)

* Add linting and fix litner errors

* Address PR comment:
 - Use author name instead of user
 - Remove ROS2 maintainer (remnants of older porting)

* apply env_var to  use_sim_time (autowarefoundation#222)

* [gnss_poser] fix namespace for component (autowarefoundation#295)

Signed-off-by: Takamasa Horibe <[email protected]>

* [gnss_poser] fix link to Geographiclib (autowarefoundation#296)

* [gnss_poser] fix link to Geographiclib

* Fix mismatching spaces inside () after command

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Autoware <[email protected]>
Co-authored-by: wep21 <[email protected]>

* Ros2 v0.8.0 gnss poser (autowarefoundation#287)

* [gnss poser]: Remove std_msgs (autowarefoundation#341)

Signed-off-by: wep21 <[email protected]>

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <[email protected]>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <[email protected]>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <[email protected]>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: pre-commit <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* suppress warnings for sensing packages (autowarefoundation#1729)

* add Werror for tier4_pcl_extensions

* use std::type  instead of pcl::type

* use std::isfinite instead of pcl_isfinite

* fix getFieldIndex

* add Werror

* fix uninitialized

* add Werror

* fix string to char*

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>

* Fix clang warnings (autowarefoundation#1859)

* Fix -Wreturn-std-move

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wnonportable-include-path for mussp

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-const-variable

Signed-off-by: Kenji Miyake <[email protected]>

* Fix "can not be used when making a shared object"

Signed-off-by: Kenji Miyake <[email protected]>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* fix gnss_poser transform (autowarefoundation#1493) (autowarefoundation#1623)

* fix gnss_poser transform (autowarefoundation#1493)

* fix gnss_poser transform

* change transformation method from doTransform to tf2::Transform multiplication

* rename tf variables

* correct variable spelling

Signed-off-by: wep21 <[email protected]>

* Fix lint

Signed-off-by: wep21 <[email protected]>

Co-authored-by: hiro-ya-iv <[email protected]>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* remove COLCON_IGNORE (autowarefoundation#515)

* doc gnss poser (autowarefoundation#580)

* add minimal doc

* fix document title

* doc geo conv pos (autowarefoundation#573)

* add minimal doc

* fix document title

* Remove template comments from node documents (autowarefoundation#608)

* rename document file

* remove template comment

Co-authored-by: YamatoAndo <[email protected]>
Co-authored-by: Daichi Murakami <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Jilada Eccleston <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Frederik Beaujean <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Autoware <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: pre-commit <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: hiro-ya-iv <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
@boyali boyali force-pushed the ali/simple_planning_simulator_with_disturbance_generator branch from 328d14c to a6eb350 Compare May 26, 2022 14:06
@boyali boyali force-pushed the ali/simple_planning_simulator_with_disturbance_generator branch from a6eb350 to 351ec1d Compare May 31, 2022 02:02
@boyali boyali force-pushed the ali/simple_planning_simulator_with_disturbance_generator branch from b8533e7 to e6a8638 Compare June 6, 2022 06:51
@mitsudome-r
Copy link
Member

@boyali @TakaHoribe Could you share the current status of this PR?
This seems to be inactive for three weeks.

@boyali
Copy link
Contributor Author

boyali commented Jun 29, 2022

@mitsudome-r -san, @TakaHoribe -san will decide.

@boyali boyali closed this Jul 19, 2022
@boyali boyali deleted the ali/simple_planning_simulator_with_disturbance_generator branch July 19, 2022 02:35
soblin added a commit to soblin/autoware.universe that referenced this pull request Jun 13, 2023
…dation#573)

* refactor: intersection module (autowarefoundation#3899)

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jun 19, 2023
…dation#573)

* refactor: intersection module (autowarefoundation#3899)

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <[email protected]>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <[email protected]>

Signed-off-by: GitHub <[email protected]>
Co-authored-by: kenji-miyake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants