-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): remove use_experimental_lane_change_function #5889
Merged
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:refactor/remove-use-experimental-lane-change
Dec 18, 2023
Merged
refactor(behavior_path_planner): remove use_experimental_lane_change_function #5889
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:refactor/remove-use-experimental-lane-change
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Dec 16, 2023
takayuki5168
changed the title
refactor(behavior_path_planner): remove use_experimental_lane_change_…
refactor(behavior_path_planner): remove use_experimental_lane_change_function
Dec 16, 2023
takayuki5168
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4,
zulfaqar-azmi-t4,
mkuri,
soblin and
taikitanaka3
as code owners
December 16, 2023 05:29
takayuki5168
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 16, 2023
4 tasks
kyoichi-sugahara
approved these changes
Dec 16, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5889 +/- ##
=======================================
Coverage 15.30% 15.30%
=======================================
Files 1747 1747
Lines 120119 120119
Branches 36570 36570
=======================================
Hits 18380 18380
Misses 81124 81124
Partials 20615 20615
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
deleted the
refactor/remove-use-experimental-lane-change
branch
December 18, 2023 05:05
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…function (autowarefoundation#5889) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…function (autowarefoundation#5889) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…function (autowarefoundation#5889) Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…function (autowarefoundation#5889) Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…function (autowarefoundation#5889) Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the unnecessary parameter of
use_experimental_lane_change_function
which was introduced by autowarefoundation/autoware_launch#418 but is currently not used.Tests performed
psim
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.