Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): remove use_experimental_lane_change_function #5889

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 16, 2023

Description

Removed the unnecessary parameter of use_experimental_lane_change_function which was introduced by autowarefoundation/autoware_launch#418 but is currently not used.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 16, 2023
@takayuki5168 takayuki5168 changed the title refactor(behavior_path_planner): remove use_experimental_lane_change_… refactor(behavior_path_planner): remove use_experimental_lane_change_function Dec 16, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 16, 2023 05:29
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad9778e) 15.30% compared to head (9be7b1a) 15.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5889   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files        1747     1747           
  Lines      120119   120119           
  Branches    36570    36570           
=======================================
  Hits        18380    18380           
  Misses      81124    81124           
  Partials    20615    20615           
Flag Coverage Δ *Carryforward flag
differential 9.37% <ø> (?)
total 15.30% <ø> (ø) Carriedforward from ad9778e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 68e7434 into autowarefoundation:main Dec 18, 2023
44 of 45 checks passed
@takayuki5168 takayuki5168 deleted the refactor/remove-use-experimental-lane-change branch December 18, 2023 05:05
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants