Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start/goal_planner): remove unused param and update time horizon for goal planner's safety check #6353

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Feb 7, 2024

Description

remove unused param and update time horizon for goal planner's safety check

launcher change in this PR should be merged first

Tests performed

confirmed goal planner's safety check properly working

Screencast.from.2024.02.07.21.56.46.webm

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 7, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start/goal_planner) remove unused param and update time horizon for goal planner's safety check refactor(start/goal_planner): remove unused param and update time horizon for goal planner's safety check Feb 7, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review February 7, 2024 12:59
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2bd68f) 14.86% compared to head (1d9d06f) 14.86%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6353   +/-   ##
=======================================
  Coverage   14.86%   14.86%           
=======================================
  Files        1845     1845           
  Lines      126611   126611           
  Branches    37871    37871           
=======================================
  Hits        18822    18822           
  Misses      86632    86632           
  Partials    21157    21157           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.86% <ø> (ø) Carriedforward from e2bd68f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start/goal_planner): remove unused param and update time horizon for goal planner's safety check feat(start/goal_planner): remove unused param and update time horizon for goal planner's safety check Feb 7, 2024
@kyoichi-sugahara kyoichi-sugahara merged commit 9f1ae6d into autowarefoundation:main Feb 7, 2024
38 of 41 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/remove_unused_param_and_fix_time_horizon branch February 7, 2024 16:25
kyoichi-sugahara added a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Feb 7, 2024
… for goal planner's safety check (autowarefoundation#6353)

* remove unused parameter

Signed-off-by: kyoichi-sugahara <[email protected]>

* update safety check time horizon

Signed-off-by: kyoichi-sugahara <[email protected]>

* update readme

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
… for goal planner's safety check (autowarefoundation#6353)

* remove unused parameter

Signed-off-by: kyoichi-sugahara <[email protected]>

* update safety check time horizon

Signed-off-by: kyoichi-sugahara <[email protected]>

* update readme

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… for goal planner's safety check (autowarefoundation#6353)

* remove unused parameter

Signed-off-by: kyoichi-sugahara <[email protected]>

* update safety check time horizon

Signed-off-by: kyoichi-sugahara <[email protected]>

* update readme

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants