Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnostic_graph_aggregator): update tools #6614

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Mar 14, 2024

Description

Update following tools.

  • dump
  • converter
  • tree

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Mar 14, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Mar 14, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 14, 2024
@isamu-takagi isamu-takagi enabled auto-merge (squash) March 14, 2024 04:04
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (f9fbd39) to head (720b066).
Report is 2 commits behind head on main.

Files Patch % Lines
...diagnostic_graph_aggregator/src/node/converter.cpp 0.00% 33 Missing ⚠️
...stem/diagnostic_graph_aggregator/src/tool/tree.cpp 0.00% 24 Missing ⚠️
...gnostic_graph_aggregator/src/tool/utils/loader.cpp 0.00% 21 Missing ⚠️
.../diagnostic_graph_aggregator/src/tool/plantuml.cpp 0.00% 14 Missing ⚠️
...iagnostic_graph_aggregator/src/node/aggregator.cpp 0.00% 4 Missing ⚠️
...diagnostic_graph_aggregator/src/node/converter.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6614      +/-   ##
==========================================
- Coverage   14.79%   14.78%   -0.02%     
==========================================
  Files        1920     1924       +4     
  Lines      132379   132441      +62     
  Branches    39345    39338       -7     
==========================================
- Hits        19584    19579       -5     
- Misses      90950    91023      +73     
+ Partials    21845    21839       -6     
Flag Coverage Δ *Carryforward flag
differential 37.64% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 257e530

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Great!

image

@isamu-takagi isamu-takagi merged commit 5a6c82e into autowarefoundation:main Mar 15, 2024
23 of 25 checks passed
@isamu-takagi isamu-takagi deleted the feat/diag-graph-agg-tools branch March 15, 2024 01:33
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Mar 15, 2024
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 18, 2024
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 18, 2024
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Mar 21, 2024
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants