feat(diagnostic_graph_aggregator): update tools #6614
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 4 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method converter.cpp: ConverterNode::on_graph
- Complex Method tree.cpp: dump_root
- Bumpy Road Ahead converter.cpp: ConverterNode::on_graph
- Bumpy Road Ahead tree.cpp: dump_root
Annotations
Check warning on line 117 in system/diagnostic_graph_aggregator/src/node/converter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
ConverterNode::on_graph has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 117 in system/diagnostic_graph_aggregator/src/node/converter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
ConverterNode::on_graph has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 58 in system/diagnostic_graph_aggregator/src/tool/tree.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
dump_root has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 58 in system/diagnostic_graph_aggregator/src/tool/tree.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
dump_root has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.