fix(control_launch): change default mpc param to improve performance #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <[email protected]>
|
@TakaHoribe thank you! |
TakaHoribe
force-pushed
the
fix/default-mpc-param
branch
from
d125aec
to
3ed3e48
Compare
TakaHoribe
changed the title
rej55
reviewed
Apr 11, 2022
launch/tier4_control_launch/config/trajectory_follower/lateral_controller.param.yaml
Show resolved
Hide resolved
13304490790
pushed a commit
to 13304490790/autoware.universe
that referenced
this pull request
Apr 12, 2022
* release v0.4.0 * Add map diag (autowarefoundation#688) Signed-off-by: Kenji Miyake <[email protected]> * Change default value of disengage_on_route (autowarefoundation#703) Signed-off-by: Kenji Miyake <[email protected]> * Change localization diag namespace (autowarefoundation#718) * Change default value of output_diagnostics_topic Signed-off-by: Kenji Miyake <[email protected]> * Remove localization_diagnostic.js from web_controller Signed-off-by: Kenji Miyake <[email protected]> * Integrate localization diag to diagnostic_aggregator Signed-off-by: Kenji Miyake <[email protected]> * Delete old and unused publisher Signed-off-by: Kenji Miyake <[email protected]> * Support error in autoware state (autowarefoundation#728) * Support Error in autoware_state_monitor Signed-off-by: Kenji Miyake <[email protected]> * Refactor autoware_state_monitor Signed-off-by: Kenji Miyake <[email protected]> * Wait after planning completed Signed-off-by: Kenji Miyake <[email protected]> * Integrate FailedToArriveGoal and Error into Emergency state Signed-off-by: Kenji Miyake <[email protected]> * Remove override after arrived goal in autoware_state_monitor (autowarefoundation#737) Signed-off-by: Kenji Miyake <[email protected]> * Improve autoware state monitor diag (autowarefoundation#792) * Add ok_list to stats Signed-off-by: Kenji Miyake <[email protected]> * Use key-value Signed-off-by: Kenji Miyake <[email protected]> * Add ok_list Signed-off-by: Kenji Miyake <[email protected]> * Fix format Signed-off-by: Kenji Miyake <[email protected]> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <[email protected]> * Revert "remove ROS1 packages temporarily" This reverts commit 470b35a4a07baca60033f7b363dba2f4279ff9c7. Signed-off-by: mitsudome-r <[email protected]> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <[email protected]> * Rename launch files to launch.xml (autowarefoundation#28) * [WIP] ROS2 Porting: autoware_state_monitor (autowarefoundation#81) * Fix CMake and package.xml - Remove topic_tools deps in package.xml - Fix cmake refs - Build just core without other deps * Remove colcon ignore * Convert CMake to ament_cmake_auto * Fix package.xml with correct deps - Remove topic tools * Convert yaml files to be ROS2 compliant - Previous XmlRpc was used to collect yaml array like structures - Use _configs.names string array to locate config.<name>.<field> - Will need to convert the way the parametersa are retrieved * First pass - make compile * Port headers - Change the name of arrived goal for consistency - Port state machine - Port diagnostics wrapper methods * Add subscription, publisher and timers - Add simple parameters - Add back functionality - Add topic state functionality - Add functionality * Add configuration parameter implementations * Add launch files and clean up - Remove commented code from cmake and package.xml - Remove rosconsole.h * Clean up - Remove changes to autoware_sysytem_msgs - remove comments * Added types to the launch files - Make type arrays to allow for multiple types * Add rclcpp_generic implementation for subscriptions - Add the callback method back - Include exec_depends in package.xml * Clean up - Remove boost dependencies - Remove commented out dependencies - Remove comments * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * Add linters and fix some clang-tidy warnings (autowarefoundation#205) * [autoware_state_monitor] fix parameter in autoware_state_monitor.planning_simulation.yaml (autowarefoundation#244) Signed-off-by: mitsudome-r <[email protected]> * Modify autoware state monitor (autowarefoundation#288) * comment out param config Signed-off-by: Kosuke Murakami <[email protected]> * fix minor issues Signed-off-by: Kosuke Murakami <[email protected]> * change engage from bool to control msg (autowarefoundation#292) Signed-off-by: Kosuke Murakami <[email protected]> * Ros2 v0.8.0 autoware state monitor (autowarefoundation#277) * Ros2 v0.8.0 engage (autowarefoundation#342) * [autoware_vehicle_msgs]: Add engage message Signed-off-by: wep21 <[email protected]> * [as]: Update message Signed-off-by: wep21 <[email protected]> * [awapi_awiv_adapter]: Update message Signed-off-by: wep21 <[email protected]> * [web_controller]: Update message Signed-off-by: wep21 <[email protected]> * [vehicle_cmd_gate]: Update message Signed-off-by: wep21 <[email protected]> * [autoware_state_monitor]: Update message Signed-off-by: wep21 <[email protected]> * [autoware_control_msgs]: Remove EngageMode message Signed-off-by: wep21 <[email protected]> * [simple_planning_simulator]: Update message Signed-off-by: wep21 <[email protected]> * Fix invalid exception handling (autowarefoundation#344) * remove invalid exception handling Signed-off-by: Kosuke Murakami <[email protected]> * remove unnecessary topics Signed-off-by: Kosuke Murakami <[email protected]> * Ros2 v0.8.0 fix packages (autowarefoundation#351) * add subscription to QoS * add vihicle_param _file to simple_planning_sim * update cmake/packages.xml * comment out unused parameter * apply lint * add vehicle_info_util to lane_change_planner * add vehicle_info_util to vehicle_cmd_gate * fix cmake of simple planning simulator * update cmake/packages.xml of vehicle cmd gate * apply lint * apply lint * add latch option to autoware_state_monitor * delete unused comment * fix implement miss in autoware_state_monitor * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <[email protected]> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <[email protected]> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <[email protected]> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <[email protected]> * Fix overlooked parameters Signed-off-by: Kenji Miyake <[email protected]> * Ros2 v0.8.0 fix packages2 (autowarefoundation#354) * fix topic name * fix duration rate * fix sensing.yaml * fix topic name * add latch-option to autoware_state_monitor * fix timer callback * fix autoware state monitor config * fix sensing.yaml * Add parameter args to autoware_state_monitor.launch (autowarefoundation#1175) (autowarefoundation#385) Signed-off-by: Kenji Miyake <[email protected]> * Feature/Add route cancel service (autowarefoundation#384) * Feature/Add route cancel service (autowarefoundation#1100) * Feature/Add route cancel service Signed-off-by: Kenji Miyake <[email protected]> * Add guard Signed-off-by: Kenji Miyake <[email protected]> * fix service name in launch Signed-off-by: mitsudome-r <[email protected]> * remove spin_some within service callback functions Signed-off-by: mitsudome-r <[email protected]> * apply ament_uncrustify Signed-off-by: mitsudome-r <[email protected]> * change wait time for state transition (autowarefoundation#416) * Sensor data qos (autowarefoundation#407) * Use sensor data qos for pointcloud preprocessor Signed-off-by: Autoware <[email protected]> * Use sensor data qos for pointcloud Signed-off-by: Autoware <[email protected]> * Fix lint Signed-off-by: wep21 <[email protected]> * Use sensor data qos for livox tag filter and vector map filter Signed-off-by: wep21 <[email protected]> * Fix lint Signed-off-by: wep21 <[email protected]> Co-authored-by: Autoware <[email protected]> * Fix typo in system module (autowarefoundation#434) * Fix typo in system module * Change variable name * Move comments * Apply uncrustify * add use_sim-time option (autowarefoundation#454) * add missing topic to topic config list (autowarefoundation#1224) * remove pointcloud from state_monitor (autowarefoundation#1236) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <[email protected]> * Use integrated generic subscription (autowarefoundation#1342) Signed-off-by: wep21 <[email protected]> * suppress warnings for autoware_state_monitor (autowarefoundation#1722) * suppress warnings for autoware_state_monitor * fix style * re fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <[email protected]> * Fix mistake Signed-off-by: Kenji Miyake <[email protected]> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <[email protected]> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> * Sync v1.3.0 (autowarefoundation#1909) * Add elevation_map to autoware_state_monitor (autowarefoundation#1907) Signed-off-by: kosuke55 <[email protected]> * Disable saving elevation map temporarily (autowarefoundation#1906) Signed-off-by: kosuke55 <[email protected]> * sync rc (autowarefoundation#1930) * Remove elevation_map from autoware_state_monitor (autowarefoundation#1922) Signed-off-by: kosuke55 <[email protected]> * Use base_ref (autowarefoundation#1925) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * Add autoware api (autowarefoundation#1979) * suport auto recovery on autoware_state_monitor (autowarefoundation#2006) * disable emergency check if hazard_status is not received (autowarefoundation#2024) * suppress warnings for system directory autowarefoundation#2046 * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Added warning about lookupTransform failure in autoware_status_monitor (autowarefoundation#2099) * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <[email protected]> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <[email protected]> * Apply Black Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <[email protected]> * [autoware state monitor] support autoware.auto msg (autowarefoundation#521) * support autoware.auto msg * add readme * remove unused code * remove emergency state * stop to subscribe hazard_status * remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549) * fix autoware_error_monitor * fix state monitor * fix emergency handler(vehicle_state_report) * fix emergency Handler(vehicle_state_command) * fix shift_decider * fix emergency_handler(vehicle_control_command) * fix topic name * fix readme * Update system/autoware_state_monitor/Readme.md Co-authored-by: taikitanaka3 <[email protected]> * fix format * Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml Co-authored-by: taikitanaka3 <[email protected]> * fix typo Co-authored-by: taikitanaka3 <[email protected]> * [autowere_web_controller/autoware_state_monitor/emergency_handler]fix some packages (autowarefoundation#603) * fix vehicle_engage.js * fix autoware_state_monitor param * fix emergency_handler * oh * update autoware_state.js * [autoware_state_monitor]route -> had_map_route (autowarefoundation#635) * route -> had_map_route * Rename Readme.md to README.md Co-authored-by: Takayuki Murooka <[email protected]> * Fix autoware monitors readme (autowarefoundation#629) * Fix readme of autoware_state_monitor * Fix readme of autoware_error_monitor * adapt to actuation cmd/status as control msg (autowarefoundation#646) * adapt to actuation cmd/status as control msg * fix readme * fix topics * fix remaing topics * as to pacmod interface * fix vehicle status * add header to twist * revert gyro_odometer_change * revert twist topic change * revert unchanged package * Fix topic name in autoware_state_monitor (autowarefoundation#667) * Fix no ground pointcloud topic name (autowarefoundation#733) Signed-off-by: j4tfwm6z <[email protected]> Co-authored-by: j4tfwm6z <[email protected]> * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Nikolai Morin <[email protected]> Co-authored-by: Jilada Eccleston <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Kosuke Murakami <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Autoware <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Taichi Higashide <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: Yohei Mishina <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: j4tfwm6z <[email protected]> Co-authored-by: Satoshi OTA <[email protected]> Co-authored-by: Takeshi Miura <[email protected]>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
…ier4#667) Signed-off-by: Takamasa Horibe <[email protected]>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ier4#667) Signed-off-by: Takamasa Horibe <[email protected]>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ier4#667) Signed-off-by: Takamasa Horibe <[email protected]>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
…ier4#667) Signed-off-by: Takamasa Horibe <[email protected]>
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Jul 25, 2023
…towarefoundation#4283) (autowarefoundation#667) fix(intersection): fix uninitialized tl_arrow_info variable issue (autowarefoundation#4283) * update first conflicting/attention area * debug 1113, 1393 * migrated to latest --------- Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For #641, change default mpc parameter to improve performance for the sample-vehicle (mentioned in #641 (comment)).
Please check the tracking performance is improved following the planning-simulator tutorial.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.